Date: Mon, 14 Nov 2016 19:48:02 -0800 From: Mark Millard <markmi@dsl-only.net> To: freebsd-arm <freebsd-arm@freebsd.org>, FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org> Cc: FreeBSD Toolchain <freebsd-toolchain@freebsd.org>, Bryan Drewery <bdrewery@FreeBSD.org> Subject: Re: stable/11 -r308135 Build for RPI2 failed for: . . ./bcm2835_ft5406.c:65:10: fatal error: 'mbox_if.h' file not found [Fixed] Message-ID: <0DCE9672-3FD4-4CC0-9B2A-6E25A21F83ED@dsl-only.net> In-Reply-To: <8400BD9A-E08C-4578-8409-274B1BC30C98@dsl-only.net> References: <B5225D04-5323-42FE-863F-883A8D030764@dsl-only.net> <8400BD9A-E08C-4578-8409-274B1BC30C98@dsl-only.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2016-Nov-2, at 12:16 PM, Mark Millard <markmi at dsl-only.net> wrote:
> Quick top post reporting that a build-order-race for -j use seems =
likely: the clean-then-build sequence
>=20
>> Command: env __MAKE_CONF=3D/root/src.configs/make.conf =
SRC_ENV_CONF=3D/root/src.configs/src.conf.rpi2-clang-bootstrap.amd64-host =
WITH_META_MODE=3Dyes MAKEOBJDIRPREFIX=3D/usr/obj/rpi2_clang make =
cleanworld
>>=20
>> Command: env __MAKE_CONF=3D/root/src.configs/make.conf =
SRC_ENV_CONF=3D/root/src.configs/src.conf.rpi2-clang-bootstrap.amd64-host =
WITH_META_MODE=3Dyes MAKEOBJDIRPREFIX=3D/usr/obj/rpi2_clang make -j 5 =
buildworld buildkernel
>=20
> that used -j 5 for buildworld buildkernel got the problem again. But =
following that failure by doing just buildkernel without the -j 5:
>=20
>> Command: env __MAKE_CONF=3D/root/src.configs/make.conf =
SRC_ENV_CONF=3D/root/src.configs/src.conf.rpi2-clang-bootstrap.amd64-host =
WITH_META_MODE=3Dyes MAKEOBJDIRPREFIX=3D/usr/obj/rpi2_clang make =
buildkernel
>=20
> completed the rest of the build just fine, creating the =
previously-missing file before trying to use it.
>=20
>=20
> =3D=3D=3D
> Mark Millard
> markmi at dsl-only.net
>=20
> On 2016-Nov-2, at 3:13 AM, Mark Millard <markmi at dsl-only.net> =
wrote:
>=20
>> Lack of dependency? Race? (I've not isolated why this happened yet =
but I was using -j 5 for buildworld buildkernel .)
>>=20
>> This was a cross-build attempt from an amd64 context:
>>=20
>> # uname -apKU
>> FreeBSD FreeBSDx64 11.0-STABLE FreeBSD 11.0-STABLE #1 r308135M: Tue =
Nov 1 23:48:47 PDT 2016 =
root@FreeBSDx64:/usr/obj/amd64_clang/amd64.amd64/usr/src/sys/GENERIC-NODBG=
amd64 amd64 1100506 1100506
>>=20
>> # svnlite info /usr/src/ | grep "Re[lv]"
>> Relative URL: ^/stable/11
>> Revision: 308135
>> Last Changed Rev: 308135
>>=20
>> # find /usr/src/sys/ -name "*files*" -exec grep mbox_if {} \; -print =
| more
>> dev/mbox/mbox_if.m standard
>> /usr/src/sys/arm/broadcom/bcm2835/files.bcm283x
>> dev/mbox/mbox_if.m optional =
ti_mbox
>> /usr/src/sys/arm/ti/files.ti
>>=20
>> # find /usr/obj/rpi2_clang/arm.armv6/ -name mbox_if.h -print | more =
=
=
=20
>> #
>>=20
>> (So no mbox_if.h file is present in the build tree.)
>>=20
>> # head =
~/sys_typescripts/typescript_make_rpi2_nodebug_clang_bootstrap-amd64-host-=
2016-11-02:00:59:43
>> Script started on Wed Nov 2 00:59:43 2016
>> Command: env __MAKE_CONF=3D/root/src.configs/make.conf =
SRC_ENV_CONF=3D/root/src.configs/src.conf.rpi2-clang-bootstrap.amd64-host =
WITH_META_MODE=3Dyes MAKEOBJDIRPREFIX=3D/usr/obj/rpi2_clang make -j 5 =
buildworld buildkernel
>> . . .
>> --- all_subdir_rpi_ft5406 ---
>> --- bcm2835_ft5406.o ---
>> =
/usr/src/sys/modules/rpi_ft5406/../../arm/broadcom/bcm2835//bcm2835_ft5406=
.c:65:10: fatal error: 'mbox_if.h' file not found
>> #include "mbox_if.h"
>> ^
>> 1 error generated.
>> *** [bcm2835_ft5406.o] Error code 1
. . .
Looks like stable/11 -r308655 fix this. (-r308581 for head.) :
Author: gonzo
Date: Mon Nov 14 22:39:33 2016
New Revision: 308655
URL:=20
https://svnweb.freebsd.org/changeset/base/308655
Log:
MFC r308581:
=20
[rpi_ft5406] Add missing dependency on mbox_if.h
=20
Submitted by: hselasky
Modified:
stable/11/sys/modules/rpi_ft5406/Makefile
Directory Properties:
stable/11/ (props changed)
Modified: stable/11/sys/modules/rpi_ft5406/Makefile
=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
--- stable/11/sys/modules/rpi_ft5406/Makefile Mon Nov 14 22:33:57 2016 =
(r308654)
+++ stable/11/sys/modules/rpi_ft5406/Makefile Mon Nov 14 22:39:33 2016 =
(r308655)
@@ -5,6 +5,6 @@
KMOD=3D rpi_ft5406
SRCS=3D bcm2835_ft5406.c
=20
-SRCS+=3D bus_if.h device_if.h ofw_bus_if.h
+SRCS+=3D bus_if.h device_if.h mbox_if.h ofw_bus_if.h
=20
.include <bsd.kmod.mk>
=3D=3D=3D
Mark Millard
markmi at dsl-only.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0DCE9672-3FD4-4CC0-9B2A-6E25A21F83ED>