Date: Sun, 02 Jun 2024 14:05:18 -0400 From: Olivier Certner <olce@freebsd.org> To: Warner Losh <imp@freebsd.org>, Nuno Teixeira <eduardo@freebsd.org>, Cy Schubert <Cy.Schubert@cschubert.com> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 108de784513d - main - Redefine CLOCK_BOOTTIME to alias CLOCK_MONOTONIC, not CLOCK_UPTIME Message-ID: <3049031.hHqAuc6tWs@francois> In-Reply-To: <20240601224055.6a6cac10@slippy> References: <202405311447.44VEl1G1078199@gitrepo.freebsd.org> <CAFDf7ULP1X_LgDOrKhMEFF7AgBQPPaJGhbRsaNcUpUOBo9JN9g@mail.gmail.com> <20240601224055.6a6cac10@slippy>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart2418096.THHZn3L5Ee Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Olivier Certner <olce@freebsd.org> Date: Sun, 02 Jun 2024 14:05:18 -0400 Message-ID: <3049031.hHqAuc6tWs@francois> Organization: FreeBSD In-Reply-To: <20240601224055.6a6cac10@slippy> MIME-Version: 1.0 Hi, Some food for thought. Given the (minor?) fallout, I wonder if we should have instead just added a distinct numerical value for CLOCK_BOOTTIME, which didn't occur to me while doing the review. This would have the benefit of allowing all these 'case' labels to coexist, which makes the interface more predictable and thus easier on applications. The patches below obviously only can cover the precise applications that we noticed failed to compile, and not other existing ones nor future ones to be written. I don't see any real drawback for such an approach because, to read clock information, applications always have to specify the clock ID and, AFAIK, cannot, e.g., request a list of clocks and times, where we would have to be careful to output the same time for all the aliased clock IDs. Thanks. -- Olivier Certner --nextPart2418096.THHZn3L5Ee Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmZctF4ACgkQjKEwQJce JidbYQ/+IscfV9GyJbYl3pvI6m8KbEd8UzX5Z6Pm/udJM3xCa9mKysIzDgQkDAMQ Oc9xEH/dMCLzbIlp2r4p53RLfGTnvEVzPzIWcAFWOnxaBXK+uFKhul4WURdRl97B C2Vxvp0H258Eg76PxDT9Ljgvs/kCPLsp+AD2XeNc51iZ04TXNFaGQqn7wv7TdCL0 DYXUX91Qwum7W8EZGpdRy5XyXkMFW3qEUKmGy61QTQ4DH03yeZhE52nxx/1mF0HJ /b3sRLwAnqZ3L7ZdEwE6I/vG7GTfbIzZi3lv/aSID1Wa3t1iNU9Yr4m3s+Nq57XK 2LdqjdULT8RsQ0woRE0XVq1ndQJ57xZuUnBh/Qd+63BlqVc6xcB2ZKoiF98Csj0Q LCTf5qvPVvOuxpmiUYPmRwZTJOsE3d7U2pPsIDy56ynTUIzRfYqzueNas3CqDXjg MkMfsgYjisrSiHgOF9KPg8oWmRnxiX6AjFhcf2JwaWgK6dAXuSqWZ36Ulo+HL1lB EmAUlaBK/M7bPejYaQ75/r80VK3mRL5xsMs2TH4wvtQvTG6q0Wss7QtrHfXfix9m fLyGCXMpGswLY6XdKxDkXjN/55eefxh0Xsz6WqU27TM4p0Rw/LToQdS5qL3nBqLR rqxK5vH2kGKuH2EY4CzNYi5gLaI+F3vAmO+QPGM+BxcMdO1wDq0= =KwGd -----END PGP SIGNATURE----- --nextPart2418096.THHZn3L5Ee--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3049031.hHqAuc6tWs>