Date: Thu, 05 Aug 2004 10:56:43 -0600 From: Scott Long <scottl@samsco.org> To: Brian Fundakowski Feldman <green@FreeBSD.org> Cc: Kirill Ponomarew <krion@voodoo.oberon.net> Subject: Re: cvs commit: src/contrib/gcc - Imported sources Message-ID: <411266CB.7010602@samsco.org> In-Reply-To: <20040805154106.GD58239@green.homeunix.org> References: <200407280312.i6S3C39q070966@repoman.freebsd.org> <20040805074710.GD58821@voodoo.oberon.net> <20040805150612.GC58239@green.homeunix.org> <20040805152505.GB23921@voodoo.oberon.net> <20040805154106.GD58239@green.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Brian Fundakowski Feldman wrote: > On Thu, Aug 05, 2004 at 05:25:05PM +0200, Kirill Ponomarew wrote: > >>Hi, >> >>On Thu, Aug 05, 2004 at 11:06:13AM -0400, Brian Fundakowski Feldman wrote: >> >>>>Could you please bump __FreeBSD_version ? >>> >>>It has been bumped twice since then already: >>>http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/sys/param.h >> >>Yes, but not for gcc import, it's also important for ports >>infrastructure. > > > It is not important why it was bumped, after the fact, except for noting > it in the commit log. The OSRELDATE when it happened is still in the past > and a new one does not need to be added. You can cvs ci -f it to add > a note in the commit log that the previous revision happened to include > that, as well. > It's important for it to be documented. The vital piece is not in the commit log, it's in the developers handbook. It's certainly acceptable to coelesce multiple events into the same bump so long those multiple events are all properly documented. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?411266CB.7010602>