Date: Sun, 6 Oct 2019 21:07:50 -0400 From: Allan Jude <allanjude@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: Revisiting the ZFS test suite Message-ID: <34dfdd18-cc44-833a-5632-89e54182e973@freebsd.org> In-Reply-To: <CAOtMX2gbZWe0Vm6zu7ixoWBgrmcbV6xGPgyue3UUTmZpw6xg5Q@mail.gmail.com> References: <CAOtMX2hFQnnfqKSyzo7LDdmLoc==_wrxFB6fASuxgN=d=Tjk%2BA@mail.gmail.com> <0cd4df2a-dedd-5cb0-da71-37247fd7bfb4@freebsd.org> <CAOtMX2gbZWe0Vm6zu7ixoWBgrmcbV6xGPgyue3UUTmZpw6xg5Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CHM4sQDLgVZ844ABGFxz9tUOLDN7pBrMO Content-Type: multipart/mixed; boundary="W7qAUZkZLkagLrlWudYhU4Jm09wxB7RqS"; protected-headers="v1" From: Allan Jude <allanjude@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Message-ID: <34dfdd18-cc44-833a-5632-89e54182e973@freebsd.org> Subject: Re: Revisiting the ZFS test suite References: <CAOtMX2hFQnnfqKSyzo7LDdmLoc==_wrxFB6fASuxgN=d=Tjk+A@mail.gmail.com> <0cd4df2a-dedd-5cb0-da71-37247fd7bfb4@freebsd.org> <CAOtMX2gbZWe0Vm6zu7ixoWBgrmcbV6xGPgyue3UUTmZpw6xg5Q@mail.gmail.com> In-Reply-To: <CAOtMX2gbZWe0Vm6zu7ixoWBgrmcbV6xGPgyue3UUTmZpw6xg5Q@mail.gmail.com> --W7qAUZkZLkagLrlWudYhU4Jm09wxB7RqS Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2019-10-06 18:29, Alan Somers wrote: > On Sun, Oct 6, 2019 at 10:20 AM Allan Jude <allanjude@freebsd.org > <mailto:allanjude@freebsd.org>> wrote: >=20 > On 2019-10-04 12:23, Alan Somers wrote: > > My employment status changed last week, and I find myself once ag= ain > > working on ZFS.=C2=A0 It's hard to have confidence in any changes= without a > > solid test suite, so my main task right now is to fix the problem= s in > > FreeBSD's ZFS test suite.=C2=A0 Our most recent run had 64 failed= tests > and 99 > > skipped ones; let's get those down to 0 and something small, > respectively. > > > > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/3880/testRep= ort/ > > > > Would anybody be interested to review my changes to the test > suite?=C2=A0 It's > > not terrible if I have to commit without review; I can't possibly= > break > > anything but the test suite itself. > > > > -Alan > > _______________________________________________ > > freebsd-testing@freebsd.org <mailto:freebsd-testing@freebsd.org> > mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-testing > > To unsubscribe, send any mail to > "freebsd-testing-unsubscribe@freebsd.org > <mailto:freebsd-testing-unsubscribe@freebsd.org>" > > >=20 > Have you followed the work here: >=20 > https://github.com/zfsonfreebsd/ZoF >=20 > That has ported the improved ZFS test suite from ZFSonLinux back to= > FreeBSD (as part of the effort to upstream FreeBSD support into tha= t > newer version of ZFS) >=20 > --=20 > Allan Jude >=20 >=20 > Oh, boy, I didn't know about that fork of the test suite.=C2=A0 When I = made > FreeBSD's, I didn't try for portability.=C2=A0 Merging the two will not= be > easy.=C2=A0 There are > 60,000 lines of diffs between the two, plus=C2=A0= > 1,000 > files that don't exist on both sides.=C2=A0 Worse, there are some major= > structural differences: > 1) FreeBSD's test suite runs as root and drops privileges selectively, > but ZoL's runs as an unprivileged user and uses sudo selectively to gai= n > privileges > 2) FreeBSD's test suite uses ATF, just like everything else, but ZoL's > test suite uses a bespoke python program > 3) FreeBSD's test suite runs setup and cleanup once for every test file= , > but ZoL does it once for every directory of test files. > 4) FreeBSD's test suite uses FreeBSD make, but ZoL's uses autotools and= > gmake >=20 > Of those item 3 is the most troubling.=C2=A0 I wonder if ZoL could be > convinced to switch to ATF and Kyua?=C2=A0 They're pretty portable. > -Alan Yeah, so I think the ZoF project is just porting the ZoL test suite to FreeBSD, not necessarily pushing anything from ours back. It'd be good to get to keep more of our tests. The goal was really to be able to take advantage of the existing CI that ZFSonLinux has, and to require all future pull-requests against the new OpenZFS repo require passing the ZTS on both OSes to be able to be merged= =2E So the more FreeBSD stuff we can get in there the better. --=20 Allan Jude --W7qAUZkZLkagLrlWudYhU4Jm09wxB7RqS-- --CHM4sQDLgVZ844ABGFxz9tUOLDN7pBrMO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJdmo/zAAoJEBmVNT4SmAt+nrkQAJ7YYx1f0MM0PthkZmNMWKr+ 52NUMgAILbYkPW10Ya8xbM46yd+WQ/DvXHAzxh0/YmGxNi+BVlPkUDgRjLFqPX0H jJ0vzyVDnKQycN9tJhOpcMDTlMbWyYxiEVRCWtXKDCFbfJBUJZFPHl+H2CH6/HxK JGGczAdOr4T87opxGhVD4SAyjVNgrq8ONlWNQVC3tv3Cx86nahFz/OnKT3RUqAHD 8RLKWAP1XhWHKDCkOiZtjqrAAPX9Yp4FnNVc/iwyuKGdPHOpyXE9EPiwfxd7+5zf aC5KlJlacmdRKxkzqpdyLhiwSVI9ZUuOPO/u7B+PhWWzVAFn1WI8zxe95Tv0kxyn BrkhMIku36ygL87OdM88VaYrRLGz4aPcb6Op5189+iG1hD2PHgI6WwBG1sGf8OTv QWU2raFUgBcrDihEhv9ZHbNhcTEn0H1QkrfUowN0itk1U43FAreVgAsYzWO486Dw 3D82zD2td1f2ZuWgOAEK6D7LLllDKe5YXJC+ef/J3aRUh0azILJvMhjF+sI8XHY7 R1k+4n3OIKhKTTRqOK7T/sc+5XvrDJwiyTQ9Th87OA7JyMHwSPt57Trxpp8auwZ1 xWWJgYcVQjtzgXSKEZi714OQla1yI7ZLCNkHjl8tz66CmyTMU4JCnGElGNQx7xkM Ibrl1j6MmBC72oKbH3De =cGzo -----END PGP SIGNATURE----- --CHM4sQDLgVZ844ABGFxz9tUOLDN7pBrMO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?34dfdd18-cc44-833a-5632-89e54182e973>