Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Oct 2011 17:39:58 +0000 (UTC)
From:      Christian Brueffer <brueffer@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   svn commit: r226223 - stable/7/sys/dev/ips
Message-ID:  <201110101739.p9AHdwLM073402@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: brueffer
Date: Mon Oct 10 17:39:58 2011
New Revision: 226223
URL: http://svn.freebsd.org/changeset/base/226223

Log:
  MFC: r198329
  
  Check pointer for NULL before dereferencing it, not after.

Modified:
  stable/7/sys/dev/ips/ips_disk.c
Directory Properties:
  stable/7/sys/   (props changed)
  stable/7/sys/cddl/contrib/opensolaris/   (props changed)
  stable/7/sys/contrib/dev/acpica/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)

Modified: stable/7/sys/dev/ips/ips_disk.c
==============================================================================
--- stable/7/sys/dev/ips/ips_disk.c	Mon Oct 10 16:31:18 2011	(r226222)
+++ stable/7/sys/dev/ips/ips_disk.c	Mon Oct 10 17:39:58 2011	(r226223)
@@ -192,10 +192,10 @@ ipsd_dump(void *arg, void *virtual, vm_o
 
 	dp = arg;
 	dsc = dp->d_drv1;
-	sc = dsc->sc;
 
 	if (dsc == NULL)
 		return (EINVAL);
+	sc = dsc->sc;
 
 	if (ips_get_free_cmd(sc, &command, 0) != 0) {
 		printf("ipsd: failed to get cmd for dump\n");



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110101739.p9AHdwLM073402>