Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Aug 2016 12:57:41 -0700
From:      John Baldwin <jhb@freebsd.org>
To:        Ed Schouten <ed@nuxi.nl>
Cc:        Bryan Drewery <bdrewery@freebsd.org>, Guido Falsi <madpilot@freebsd.org>, svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org>
Subject:   Re: svn commit: r303988 - head/lib/libc/gen
Message-ID:  <2038784.5k3koFGWFB@ralph.baldwin.cx>
In-Reply-To: <CABh_MKnHa-djy_HVEGhCM8xAjOXwrhdP7Sh-Gr6v09nrbS5pnw@mail.gmail.com>
References:  <201608120703.u7C73whf007189@repo.freebsd.org> <1ce79adf-94cc-e5d3-7b8b-0914f2b07512@FreeBSD.org> <CABh_MKnHa-djy_HVEGhCM8xAjOXwrhdP7Sh-Gr6v09nrbS5pnw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, August 26, 2016 09:37:10 AM Ed Schouten wrote:
> Hi,
> 
> 2016-08-26 1:52 GMT+02:00 Bryan Drewery <bdrewery@freebsd.org>:
> > Libc wouldn't build, it complained quite loudly with a lot of these:
> 
> Got it. Thinking ahead, if it's just basename() giving the problems,
> maybe it's easier to just go ahead and bump the symver of basename()
> as well? I'm planning on replacing it anyway to be in sync with the
> new basename() anyway. Attached is a new patch. Be sure to let me know
> whether that works for you.

Alternatively, couldn't you just leave basename out of the libgen patch
for now and only add it once you do the real symver bump for the
different version?  (That is, just use __generic() for dirname() for
now since that is the only one that has really changed.)

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2038784.5k3koFGWFB>