Date: Thu, 22 Jan 2015 10:21:50 +0100 From: Erik Cederstrand <erik@cederstrand.dk> To: Hans Petter Selasky <hps@selasky.org> Cc: Kostik Belousov <kostikbel@gmail.com>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys Message-ID: <A0C38C20-7432-4790-8FC6-11E98E57CEF8@cederstrand.dk> In-Reply-To: <54C0B75B.9070305@selasky.org> References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <CAJ-Vmok0GXZoojyi=jE=b5D-d338APztaf3Pw0_AAQ-173XSWw@mail.gmail.com> <54BDD9E1.6090505@selasky.org> <20150120075126.GA42409@kib.kiev.ua> <54BE0AAA.4050104@selasky.org> <20150120090057.GD42409@kib.kiev.ua> <54BE21F0.6010602@selasky.org> <7C692107-51CF-4DFA-BD6C-623D56893150@bsdimp.com> <54C0A352.8090701@selasky.org> <20150122081023.GT42409@kib.kiev.ua> <54C0B75B.9070305@selasky.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > Den 22/01/2015 kl. 09.39 skrev Hans Petter Selasky <hps@selasky.org>: > > Are you saying that pieces of code that runs completely unlocked using "volatile" as only synchronization mechanism is better than what I would call a temporary and hopefully short TCP stack performance loss? > > I don't understand? How frequently do you reboot your boxes? Maybe one every day? And you don't care? Hans, I'm just a spectator here, but please do yourself and the project a favor and back out your change, go back to the Phabricator review once more and let the review process roll until everyone is satisfied. Although it's not very evident in this thread, I'm sure everyone actually appreciates your work. I also acknowledge that it's frustrating to back out a commit that you have spent a lot of effort on, and which fixes actual bugs. It's also frustrating to get insufficient feedback on a code review, but you certainly got people's attention now. Now you need to trust that the people voicing concerns will step up and provide constructive feedback in Phabricator, so this can be committed in a timely manner, in a quality that we expect from FreeBSD. Kind regards, Erik [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUwMEvAAoJEFWwJk18WUOGNhoP/24vIV3iwuoK0+rxRI4XgI/W 5UrPI9CrUPKihaYu9TGnd1uyfXFNnMjW1d/p/8KGET8jowLG+8Q/WYnxKZfB1lQ2 yW0PRFNwH9xNYdPiW5tMQOW8S1mBaxW6rl+BjZB8VxM3h2BM9I+eM4HENbSzC1Un nvW8P8q6jUjpDiWVJSiUGuwXP//fnVAQmL/MeecFqeJvUqVgxTWixcucBEnzBYnn cButKWRBTK8B87y7eFMSCmbEhxe0bLmn1mBKpbkzEVQCFZsLZekPqoCT2GyDOA8k B/i1qlGuMZeOWLnSg2gshCCRYYOpgwVSzqegYurz4jVvR4QGufd7c1kgc+3DxX45 jnWEMprh6XlLajgrJIUcV4unWtNAlFB8WlE3o8UR+ufHqsFu6Fmy/GPqMzy3tTfJ sRk6k+5SkVHnx+8UBEncNzYIrbHZj7f0Z0tWfg3wiLNLop2BVLBCAs6+yJnGL2Ef y17J/Kidvj9+P51Grx89KzHKt1UFi4F/1uFeYHNFA27d+1qe5LQMDI/8RfV/xiYL 7gvfBCURGPNJMTSqZbj7NTdYiQ7JoCITRtKxXHN/9XMj4+NqmWnR3O97C1Lrbu4S B5vHdQNGluS6buyfBTK3pba5oUvBxqfsK39sOmTU7YVZ9YZuTOcMhg0QPKMrd6l0 R5ucUgtZ39gk09O6bqEA =j32Y -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A0C38C20-7432-4790-8FC6-11E98E57CEF8>