Date: Fri, 19 Oct 2007 22:55:42 +0000 (UTC) From: Mike Makonnen <mtm@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/etc/rc.d amd Message-ID: <200710192255.l9JMtgR5002882@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
mtm 2007-10-19 22:55:42 UTC
FreeBSD src repository
Modified files:
etc/rc.d amd
Log:
The amd_map_program knob can potentially contain a command whose output
is then used as an argument to the amd program. This outpu may contain
newlines, but the script did not take care to strip those newlines before
apending it to rc_flags. Revision 1.72 of rc.subr(8) introduced changes that
exposed this problem (specifically putting the final eval'ed command in
quotes).[1]
Also, for correctness' sake, shell directives appended to the command-line
by the script should go into command_args, and not appended directly
to rc_flags.
Reported by: John E Hein <jhein@timing.com> [1]
Tested by: John E Hein <jhein@timing.com>
MFC after: 1 week
Revision Changes Path
1.19 +3 -2 src/etc/rc.d/amd
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710192255.l9JMtgR5002882>