Date: Sat, 17 Feb 2018 09:02:07 -0600 From: Kyle Evans <kevans@freebsd.org> To: rgrimes@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329457 - head/stand/lua Message-ID: <CACNAnaFUzfD41KqoPW5gyd0Xu1GTSeQmc8dw7T4CsMCd22Ve3g@mail.gmail.com> In-Reply-To: <CACNAnaFtR%2BY1sRt_5UR0Fqp7=sraGiPB5_VuhEWTRCM=K1Pk8A@mail.gmail.com> References: <201802171430.w1HEUdxO059087@repo.freebsd.org> <201802171439.w1HEdZD5068048@pdx.rh.CN85.dnsmgr.net> <CACNAnaGXuL2susd2LmgjqYeSPuQkd1YD94sqJ7YvimhQWxNWLQ@mail.gmail.com> <CACNAnaFtR%2BY1sRt_5UR0Fqp7=sraGiPB5_VuhEWTRCM=K1Pk8A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Feb 17, 2018 8:39 AM, "Rodney W. Grimes" <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: [ Charset UTF-8 unsupported, converting... ] > Author: kevans > Date: Sat Feb 17 14:30:39 2018 > New Revision: 329457 > URL: https://svnweb.freebsd.org/changeset/base/329457 > > Log: > stand/lua: dumpModules => lsModules > > rgrimes@ notes that this behavior is more befitting of the latter name than > the former, and I'm inclined to agree. > > Reported by: rgrimes > > Modified: > head/stand/lua/config.lua > > Modified: head/stand/lua/config.lua > ============================================================ ================== > --- head/stand/lua/config.lua Sat Feb 17 13:32:29 2018 (r329456) > +++ head/stand/lua/config.lua Sat Feb 17 14:30:39 2018 (r329457) > @@ -37,7 +37,7 @@ function config.setKey(k, n, v) > modules[k][n] = v; > end > > -function config.dumpModules() > +function config.lsModules() > print("== Dumping modules"); ^^^^^^^ I was more after this word :) > for k, v in pairs(modules) do > print(k, v.load); > > (apologies for the broken quoting, no longer near a reasonable mail client) Feel free to change it- I personally believe it's pretty obvious from the context once you see this message that these things are being dumped out to the console. It wasn't necessarily obvious from the name of the function that this was the case. Either way, this is purely a debugging aide while I was trying to figure out why it wasn't loading modules on kernel change. I don't really care much about the output as long as it still tells me just as much as it does now. As an aside, for anyone interested that reads this far, it's still handling module_path wrong but in a more subtle way. Every kernel change prepends the kernel path to module_path, and we keep building on this. Eventually you'd end up with: "/boot/kernel.GENERIC;/boot/kernel;..." So it may fallback to another kernel path for modules that may or may not match the current kernel version.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFUzfD41KqoPW5gyd0Xu1GTSeQmc8dw7T4CsMCd22Ve3g>