Date: Wed, 01 Dec 2010 13:22:20 +0100 From: Alexander Leidinger <Alexander@Leidinger.net> To: Mark Linimon <linimon@lonesome.com> Cc: emulation@freebsd.org Subject: Re: fwd: CFR: patch to cleanup usage of SRC_BASE in various ports Message-ID: <20101201132220.790748omutg2pp6o@webmail.leidinger.net> In-Reply-To: <20101130192314.GB28560@lonesome.com> References: <20101130192314.GB28560@lonesome.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Mark Linimon <linimon@lonesome.com> (from Tue, 30 Nov 2010 19:23:14 +0000): > Forwarded individually from a message initially posted to > freebsd-ports@FreeBSD.org. Note: the patch has been updated from the > version first uploaded. Hi, for the linux ports the SRC part looks OK (not tested). For the ifndef part (linux ports)... this introduces the possibility to let the user specify LINUX_OSRELEASE somewhere. And this would override what would be set in the makefile. The result of this would be that the user could spoof a version which is different from what is available. In case of the "is the linuxulator in the kernel"-test, it would cause a failure of the build/install of the port if the user has a value set. This could open up a new case of error cases in the support mails. If you have a strong argument for this change, I do not object to it, but if you do not have a strong argument, I would prefer to not get this change. Bye, Alexander. > Thanks. > > mcl > > ----- Forwarded message from Mark Linimon <linimon@lonesome.com> ----- > > From: Mark Linimon <linimon@lonesome.com> > To: ports@FreeBSD.org > Cc: linimon@FreeBSD.org > Subject: CFR: patch to cleanup usage of SRC_BASE in various ports > > I am trying to debug a problem in the package building scripts, and > in the process of debugging it, have found some inconsistencies with > ports that require kernel sources. For installations that keep their > latest sources in /usr/src, this patch should have no effect; however, > for others (such as pointyhat, which has multiple src trees) this should > fix edge conditions with 'make describe'. > > I would appreciate feedback on the following patch: > > http://people.freebsd.org/~linimon/patches/diff.out.srcbase > > Thanks. > > mcl > > ----- End forwarded message ----- > _______________________________________________ > freebsd-emulation@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-emulation > To unsubscribe, send any mail to "freebsd-emulation-unsubscribe@freebsd.org" > > -- I want to dress you up as TALLULAH BANKHEAD and cover you with VASELINE and WHEAT THINS ... http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101201132220.790748omutg2pp6o>