Date: Sat, 3 Sep 2016 01:29:45 +0200 From: Oliver Pinter <oliver.pinter@hardenedbsd.org> To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <royger@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299064 - head/sys/kern Message-ID: <CAPQ4fft-83cpzAM=ipp3Av6UpynpKktwWhhqQudxjW0unnEJGQ@mail.gmail.com> In-Reply-To: <201605041348.u44Dmxd0092688@repo.freebsd.org> References: <201605041348.u44Dmxd0092688@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi! This commit never gets MFCd back to 10-STABLE. Do you still plan to do it? On 5/4/16, Roger Pau Monn=C3=A9 <royger@freebsd.org> wrote: > Author: royger > Date: Wed May 4 13:48:59 2016 > New Revision: 299064 > URL: https://svnweb.freebsd.org/changeset/base/299064 > > Log: > rtc: fix inverted resolution check > > The current code in clock_register checks if the newly added clock has = a > resolution value higher than the current one in order to make it the > default, which is wrong. Clocks with a lower resolution value should be > better than ones with a higher resolution value, in fact with the curre= nt > code FreeBSD is always selecting the worse clock. > > Reviewed by: kib jhb jkim > Sponsored by: Citrix Systems R&D > MFC after: 2 weeks > Differential revision: https://reviews.freebsd.org/D6185 > > Modified: > head/sys/kern/subr_rtc.c > > Modified: head/sys/kern/subr_rtc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/subr_rtc.c Wed May 4 12:51:27 2016 (r299063) > +++ head/sys/kern/subr_rtc.c Wed May 4 13:48:59 2016 (r299064) > @@ -84,7 +84,7 @@ clock_register(device_t dev, long res) / > { > > if (clock_dev !=3D NULL) { > - if (clock_res > res) { > + if (clock_res <=3D res) { > if (bootverbose) > device_printf(dev, "not installed as " > "time-of-day clock: clock %s has higher " > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4fft-83cpzAM=ipp3Av6UpynpKktwWhhqQudxjW0unnEJGQ>