Date: Fri, 2 Jan 2026 09:33:49 -0800 From: "Simon J. Gerraty" <sjg@juniper.net> To: =?us-ascii?Q?=3D=3Futf-8=3FQ=3FDag-Erling=5FSm=3DC3=3DB8rgrav=3F=3D?= <des@FreeBSD.org> Cc: Mark Millard <marklmi@yahoo.com>, FreeBSD Current <freebsd-current@FreeBSD.org>, <sjg@juniper.net> Subject: Re: How do WITH_DEPEND_CLEANUP= and WITH_META_MODE= interact? To get the old WITH_META_MODE= behavior, is WITHOUT_DEPEND_CLEANUP= needed? Message-ID: <22770.1767375229@kaos.jnpr.net> In-Reply-To: <86y0mgjuz6.fsf@ltc.des.dev> References: <2C79022B-6F51-4E67-808E-206C55627D82@yahoo.com> <23.1767296340@kaos.jnpr.net> <86y0mgjuz6.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
Dag-Erling Smørgrav <des@FreeBSD.org> wrote: > > > Do I need to set > > > WITHOUT_DEPEND_CLEANUP= to have META_MODE= work as it used to? > > My guess would be yes. > > That's not a guess, that's a knee-jerk reaction to something new that > you don't understand and didn't bother to research. Its a polite way of saying "I think so". I did actually look at your patch, and do a buildworld to see what is being recorded before stating the above. AFAICT MK_DEPEND_CLEANUP=yes tracks and compares the values of all the known options (sans those known to be not relevant) and if any change, is supposed to trigger a clean of the tree. What did I miss? If my assessment of the behavior is correct, I'd argue it is unnecessary if MK_META_MODE=yes, and infact counter productive. As I noted, there are cases where you still might want to do a tree clean if using META_MODE, but changing option values shouldn't be one of them. --sjghome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?22770.1767375229>