Date: Mon, 1 Dec 2025 14:04:22 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Kristof Provost <kp@freebsd.org> Cc: Robert Clausecker <fuz@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 2fb8cbc6ef1b - main - libc/tests: add stdbit test framework and unit tests Message-ID: <6903AA87-20BC-4060-A199-4100FC7CD8EB@freebsd.org> In-Reply-To: <3E139664-C0CE-4BB9-9225-66D7D44D644E@FreeBSD.org> References: <692c9966.26e27.70621b5b@gitrepo.freebsd.org> <3E139664-C0CE-4BB9-9225-66D7D44D644E@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On 1 Dec 2025, at 13:56, Kristof Provost <kp@freebsd.org> wrote: > > On 30 Nov 2025, at 20:22, Robert Clausecker wrote: > The branch main has been updated by fuz: > URL: https://cgit.FreeBSD.org/src/commit/?id=2fb8cbc6ef1b3cc6cd60e5db07f8305623f9b044 > commit 2fb8cbc6ef1b3cc6cd60e5db07f8305623f9b044 > Author: Robert Clausecker fuz@FreeBSD.org > AuthorDate: 2025-11-18 17:33:12 +0000 > Commit: Robert Clausecker fuz@FreeBSD.org > CommitDate: 2025-11-30 19:21:52 +0000 > libc/tests: add stdbit test framework and unit tests > > This adds unit tests for all 70 functions in <stdbit.h>. > > I'm sorry for the test framework, but it makes it so I don't > have to write 70 unit tests by hand. > > Reviewed by: adrian, des > Approved by: markj (mentor) > MFC after: 1 month > Differential Revision: https://reviews.freebsd.org/D53660 > > I’m having issues running the tests now. > I get this kyua error doing kyua list in /usr/tests/lib: > kyua: E: Load of 'Kyuafile' failed: Failed to load Lua file 'Kyuafile': Kyuafile:48: Load of 'libc/Kyuafile' failed: Failed to load Lua file 'libc/Kyuafile': libc/Kyuafile:19: Load of 'libc/stdbit/Kyuafile' failed: File 'libc/stdbit/Kyuafile' not found. > > That’s presumably because there’s no Kyuafile (or indeed anything at all) in /usr/tests/lib/libc/stdbit. > It’s not immediately obvious to me what went wrong to cause that, but I’m relatively confident it’s related to this commit. > Best regards, > Kristof Because TESTSDIR is /usr/tests/lib/libc/tests/stdbit thanks to the location of libc’s tests in the src tree. That’s meant to be overridden for every subdirectory, whether by including ../Makefile.netbsd-tests, in the case of all the NetBSD-imported ones, or by manually overriding it, such as in lib/libc/tests/iconv/Makefile. It would've been nice to test these tests prior to commit. Was that not done? Jessicahelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6903AA87-20BC-4060-A199-4100FC7CD8EB>