Date: Thu, 27 Apr 2017 22:26:28 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r317543 - head/usr.sbin/bhyve Message-ID: <D484C95F-7418-478E-A396-0F220AB2E516@gmail.com> In-Reply-To: <201704280513.v3S5DRYU067517@repo.freebsd.org> References: <201704280513.v3S5DRYU067517@repo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
> On Apr 27, 2017, at 22:13, Gleb Smirnoff <glebius@FreeBSD.org> wrote: > > Author: glebius > Date: Fri Apr 28 05:13:27 2017 > New Revision: 317543 > URL: https://svnweb.freebsd.org/changeset/base/317543 > > Log: > When no "rfb" configuration specified bind to the default VNC > port instead of binding to a random one. > > Modified: > head/usr.sbin/bhyve/pci_fbuf.c > > Modified: head/usr.sbin/bhyve/pci_fbuf.c > ============================================================================== > --- head/usr.sbin/bhyve/pci_fbuf.c Fri Apr 28 05:09:51 2017 (r317542) > +++ head/usr.sbin/bhyve/pci_fbuf.c Fri Apr 28 05:13:27 2017 (r317543) > @@ -365,6 +365,8 @@ pci_fbuf_init(struct vmctx *ctx, struct > > sc->fsc_pi = pi; > > + sc->rfb_port = 5900; > + Wouldn't it be better to use getservbyname? > error = pci_fbuf_parse_opts(sc, opts); > if (error != 0) > goto done; >help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D484C95F-7418-478E-A396-0F220AB2E516>