Date: Tue, 5 Oct 2004 20:05:45 -0400 From: Brian Fundakowski Feldman <green@FreeBSD.org> To: arch@FreeBSD.org Cc: phk@FreeBSD.org Subject: GEOM modules don't wait for "init" completion Message-ID: <20041006000545.GG47017@green.homeunix.org>
next in thread | raw e-mail | index | archive | help
In src/sys/geom/geom_subr.c, g_modevent(MOD_LOAD) does not wait for completion of the class's initialization before proceeding to return success to the caller (kldload(8)). This is especially problematic for mount_mfs(8)'s use of mdctl(8) -- the first mount hardly ever succeeds. Does it not seem like this line: g_post_event(g_load_class, hh, M_WAITOK, NULL); should really be: g_waitfor_event(g_load_class, hh, M_WAITOK, NULL); ? I can't really envision situations where you would at least not want to have your control device exist before returning from a kldload(2) system call. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041006000545.GG47017>