Date: Sat, 25 Jun 2016 21:06:57 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Ivan Klymenko <fidaj@ukr.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r302194 - head/lib/libthr/thread Message-ID: <20160625180657.GG38613@kib.kiev.ua> In-Reply-To: <20160625180543.GF38613@kib.kiev.ua> References: <20160625170406.77c79b2e@nonamehost.local> <20160625140529.GW38613@kib.kiev.ua> <20160625171800.50a43746@nonamehost.local> <20160625142915.GX38613@kib.kiev.ua> <20160625175503.7c57d42b@nonamehost.local> <20160625152006.GA38613@kib.kiev.ua> <20160625190346.19a1ef0d@nonamehost.local> <20160625161615.GD38613@kib.kiev.ua> <20160625204317.0aae5c98@nonamehost.local> <20160625180543.GF38613@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 25, 2016 at 09:05:43PM +0300, Konstantin Belousov wrote:
> On Sat, Jun 25, 2016 at 08:43:17PM +0300, Ivan Klymenko wrote:
> > ./thr_mutex_test
> > thr_mutex_test: mutex_trylock 2: No error: 0
>
> Ok, there is a bug in my test, it must use errc(3) and not err(3). Please
> retest wth the updated code below. But I am sure that you would see
> EDEADLK (Resource deadlock avoided) error, which means that you have
> wrong, i.e. unpatched libthr, installed.
>
> For me, the output is
> sandy% ./pthread_errrecurse
> sandy% echo $?
> 0
>
Err, the updated test.
/* $Id: pthread_errrecurse.c,v 1.2 2016/06/25 18:02:54 kostik Exp kostik $ */
#include <err.h>
#include <errno.h>
#include <pthread.h>
int
main(void)
{
pthread_mutex_t m;
pthread_mutexattr_t ma;
int error;
error = pthread_mutexattr_init(&ma);
if (error != 0)
errc(1, error, "mutexattr_init");
error = pthread_mutexattr_settype(&ma, PTHREAD_MUTEX_ADAPTIVE_NP);
if (error != 0)
errc(1, error, "mutexattr_settype");
error = pthread_mutex_init(&m, &ma);
if (error != 0)
errc(1, error, "mutex_init");
error = pthread_mutex_trylock(&m);
if (error != 0)
errc(1, error, "mutex_trylock 1");
error = pthread_mutex_trylock(&m);
if (error != EBUSY)
errc(1, error, "mutex_trylock 2");
else if (error == 0)
errx(1, "mutex_trylock 2 succeeded");
return (0);
}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160625180657.GG38613>