Date: Thu, 22 Jan 2015 01:49:21 -0800 From: "K. Macy" <kmacy@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: Adrian Chadd <adrian@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com>, Warner Losh <imp@bsdimp.com> Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys Message-ID: <CAHM0Q_OLVhxs6XK38SVNJj5SPFzLzug5Csg8k7TddzOt0kRtXg@mail.gmail.com> In-Reply-To: <54C0B75B.9070305@selasky.org> References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <CAJ-Vmok0GXZoojyi=jE=b5D-d338APztaf3Pw0_AAQ-173XSWw@mail.gmail.com> <54BDD9E1.6090505@selasky.org> <20150120075126.GA42409@kib.kiev.ua> <54BE0AAA.4050104@selasky.org> <20150120090057.GD42409@kib.kiev.ua> <54BE21F0.6010602@selasky.org> <7C692107-51CF-4DFA-BD6C-623D56893150@bsdimp.com> <54C0A352.8090701@selasky.org> <20150122081023.GT42409@kib.kiev.ua> <54C0B75B.9070305@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>> Sigh, you still do not understand. It is your duty to identify all pieces >> which break after your change. After that, we can argue whether each of >> them is critical or not to allow the migration. But this must have been >> done before the KPI change hit the tree. >> > > Hi, > > Are you saying that pieces of code that runs completely unlocked using > "volatile" as only synchronization mechanism is better than what I would > call a temporary and hopefully short TCP stack performance loss? > Hans - The project has long standing expectations about how changes are made to core subsystems. When you hear "understand" your ego intercedes - put that aside. I told you this first this afternoon and others have repeated it several times. When you change a KPI, consumers are updated at the same time - _period_. This protocol is not up for debate. I'm glad that others have the presence of mind and fortitude to insist on this. Your work is appreciated, but whether or not you agree about this is not relevant. We're all sorry if this upsets you but this is only a temporary setback. Channelling this work through phabricator will go a long way towards smoothing over the current friction. Think about the greater goal here, not whether this is "done" now or in a week. -K
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHM0Q_OLVhxs6XK38SVNJj5SPFzLzug5Csg8k7TddzOt0kRtXg>