Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 3 Dec 2005 09:17:43 -0800 (PST)
From:      Daniel Qarras <dqarras@yahoo.com>
To:        freebsd-cvsweb@freebsd.org
Subject:   Re: CVSweb patches
Message-ID:  <20051203171743.51757.qmail@web30807.mail.mud.yahoo.com>
next in thread | raw e-mail | index | archive | help 

[-- Attachment #1 --]
Hi Ville,

and thanks for your prompt reply. Your answer to NONE issue was to be
expected and I think your point to fix log_accum instead of adding a
workaround to CVSweb makes sense.

About the other comments: I've followed your suggestions and attached
updated patches.

Thanks.


		
__________________________________ 
Start your day with Yahoo! - Make it your home page! 
http://www.yahoo.com/r/hs
[-- Attachment #2 --]
--- cvsweb-3.0.6-orig/cvsweb.cgi
+++ cvsweb-3.0.6-curr/cvsweb.cgi
@@ -1028,8 +1028,11 @@
 
       # Show last change in dir
       if ($filename) {
-        print "</td>\n<td>&nbsp;</td>\n<td class=\"age\">";
-        print readableTime(time() - $date, 0) if $date;
+        my $lastchange = readableTime(time() - $date, 0) if $date;
+        my $changeclass = "age " . $lastchange;
+        $changeclass =~ s/\d+ //;
+        print "</td>\n<td>&nbsp;</td>\n<td class=\"$changeclass\">";
+        print $lastchange;
         print "</td>\n<td class=\"author\">", htmlquote($author)
           if $show_author;
         print "</td>\n<td class=\"log\">";
@@ -1084,8 +1087,11 @@
       print '&nbsp;', &link(htmlquote($file), $url), $attic;
       print '</td><td class="graph">', graph_link($fileurl) if $allow_cvsgraph;
       print "</td>\n<td width=\"30\">", display_link($fileurl, $rev);
-      print "</td>\n<td class=\"age\">";
-      print readableTime(time() - $date, 0) if $date;
+      my $lastchange = readableTime(time() - $date, 0) if $date;
+      my $changeclass = "age " . $lastchange;
+      $changeclass =~ s/\d+ //;
+      print "</td>\n<td class=\"$changeclass\">";
+      print $lastchange;
       print "</td>\n<td class=\"author\">", htmlquote($author) if $show_author;
       print "</td>\n<td class=\"log\">";
 
--- cvsweb-3.0.6-orig/css/cvsweb.css
+++ cvsweb-3.0.6-curr/css/cvsweb.css
@@ -87,11 +87,28 @@
   text-align: center;
   width: 1%;
 }
-/* Age column */
+/* Age column, default */
 table.dir * td.age {
   font-style: italic;
   white-space: nowrap;
 }
+/* Age column for years */
+table.dir * td.years {
+  color: #000;
+}
+/* Age column for months */
+table.dir * td.months {
+  color: #0a0;
+}
+/* Age column for weeks */
+table.dir * td.weeks {
+  color: #aa0;
+}
+/* Age column for days, hours, minutes, seconds */
+table.dir * td.days,    table.dir * td.hours,
+table.dir * td.minutes, table.dir * td.seconds {
+  color: #f00;
+}
 table.dir * td.author {
   white-space: nowrap;
 }

[-- Attachment #3 --]
--- cvsweb-3.0.6-orig/css/cvsweb.css
+++ cvsweb-3.0.6-curr/css/cvsweb.css
@@ -47,26 +47,27 @@
 
 /* Directory table */
 table.dir {
-  border-right: 1px solid #ccc;
+  border-right: 0px solid #ccc;
 }
 /* Cells */
 table.dir * td {
-  border-left: 1px solid #ccc;
-  border-bottom: 1px solid #ccc;
+  border-left: 1px solid #fff;
   padding-left: 5px;
   padding-right: 5px;
 }
 /* Column headers */
 table.dir * th {
-  background-color: #ffc;
-  border: thin outset;
+  background-color: #ccc;
+  border-left: 1px solid #fff;
+  border-bottom: 1px solid #fff;
   padding-left: 5px;
   padding-right: 5px;
 }
 /* Sorted column header */
 table.dir * th.sorted {
-  background-color: #fc6;
-  border: thin inset;
+  background-color: #8f8;
+  border-left: 1px solid #fff;
+  border-bottom: 1px solid #fff;
 }
 /* Even rows */
 table.dir * tr.even {
@@ -74,7 +75,7 @@
 }
 /* Odd rows */
 table.dir * tr.odd {
-  background-color: #fff;
+  background-color: #cce;
 }
 /* File and dir name columns */
 table.dir * td.file, table.dir * td.dir {
@@ -89,6 +90,7 @@
 }
 /* Age column */
 table.dir * td.age {
+  color: #000;
   font-style: italic;
   white-space: nowrap;
 }

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051203171743.51757.qmail>