Date: Fri, 24 Apr 2020 21:48:26 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Justin Hibbits <chmeeedalf@gmail.com> Cc: Warner Losh <imp@bsdimp.com>, John Baldwin <jhb@FreeBSD.org>, src-committers <src-committers@FreeBSD.org>, svn-src-all <svn-src-all@FreeBSD.org>, svn-src-head <svn-src-head@FreeBSD.org> Subject: Re: svn commit: r360241 - head/sys/dev/ichiic Message-ID: <32d6391a-7d3f-1aaa-2441-8a88e10b94d5@FreeBSD.org> In-Reply-To: <20200424112356.6b8a867e@titan.knownspace> References: <202004240749.03O7nMSc066344@repo.freebsd.org> <CANCZdfok8rf3SWEtKA_ZHVAgPWHCzOM-95w2pP9UTTLn-9995w@mail.gmail.com> <32586115-2c82-2497-ba4c-b3471887518d@FreeBSD.org> <CANCZdfqJaBm=Jx43jU5%2BiB1KVx3f1aoSUTDB3U6z9QnPV_q6uQ@mail.gmail.com> <02449f05-6c43-9cb0-b427-34034a3c358f@FreeBSD.org> <20200424112356.6b8a867e@titan.knownspace>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24/04/2020 19:23, Justin Hibbits wrote: > Can you look at how ofw_iicbus does this? Everything works just fine > with that, and it's compiled into the iicbus module as well. Perhaps > you can pick some ideas from there. > > One thing I remember doing on the fsl_i2c driver was to just name the > driver iichb and everything worked beautifully. Yes, it was sort of a > cop-out vs adding another attachment, but it solved the problem, and > does make sense. Justin, yes, "iichb" is the only name that has special properties because of DRIVER_MODULE(iicbus, iichb, ...) in icbus.c. That's essentially the same approach that is used for gpio. Maybe it's the way. But there was something that spooked me about many drivers having the same name, but can't recall what. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?32d6391a-7d3f-1aaa-2441-8a88e10b94d5>