Date: Sat, 27 Sep 2003 05:01:01 -0700 (PDT) From: Poul-Henning Kamp <phk@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/adlink adlink.c src/sys/dev/ata ata-all.c src/sys/dev/isp isp_freebsd.c src/sys/dev/md md.c src/sys/dev/null null.c src/sys/dev/ofw openfirmio.c src/sys/geom geom_ctl.c src/sys/i386/bios smapi.c src/sys/i386/i386 elan-mmcr.c ... Message-ID: <200309271201.h8RC11VZ029295@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
phk 2003/09/27 05:01:01 PDT FreeBSD src repository Modified files: sys/dev/adlink adlink.c sys/dev/ata ata-all.c sys/dev/isp isp_freebsd.c sys/dev/md md.c sys/dev/null null.c sys/dev/ofw openfirmio.c sys/geom geom_ctl.c sys/i386/bios smapi.c sys/i386/i386 elan-mmcr.c sys/kern kern_conf.c subr_devstat.c tty_tty.c sys/netncp ncp_mod.c sys/opencrypto cryptodev.c Log: The present defaults for the open and close for device drivers which provide no methods does not make any sense, and is not used by any driver. It is a pretty hard to come up with even a theoretical concept of a device driver which would always fail open and close with ENODEV. Change the defaults to be nullopen() and nullclose() which simply does nothing. Remove explicit initializations to these from the drivers which already used them. Revision Changes Path 1.6 +0 -1 src/sys/dev/adlink/adlink.c 1.190 +0 -2 src/sys/dev/ata/ata-all.c 1.94 +0 -2 src/sys/dev/isp/isp_freebsd.c 1.106 +0 -2 src/sys/dev/md/md.c 1.20 +0 -4 src/sys/dev/null/null.c 1.7 +0 -2 src/sys/dev/ofw/openfirmio.c 1.30 +0 -2 src/sys/geom/geom_ctl.c 1.8 +0 -2 src/sys/i386/bios/smapi.c 1.18 +0 -2 src/sys/i386/i386/elan-mmcr.c 1.135 +2 -2 src/sys/kern/kern_conf.c 1.47 +0 -2 src/sys/kern/subr_devstat.c 1.51 +0 -1 src/sys/kern/tty_tty.c 1.11 +0 -2 src/sys/netncp/ncp_mod.c 1.15 +0 -1 src/sys/opencrypto/cryptodev.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200309271201.h8RC11VZ029295>