Date: Fri, 20 Jan 2012 15:06:02 +0400 From: Eygene Ryabinkin <rea@FreeBSD.org> To: Brooks Davis <brooks@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, John Baldwin <jhb@FreeBSD.org> Subject: Re: svn commit: r230007 - in head: etc etc/rc.d share/man/man8 Message-ID: <7dcvawMgnE9O34bJ7H3SrdYasTs@HbohoBmewgxm0atwUoKO7zhAAgw> In-Reply-To: <20120119172759.GC60214@lor.one-eyed-alien.net> References: <201201120648.q0C6mBio096662@svn.freebsd.org> <201201120748.28564.jhb@freebsd.org> <bCcADqQ22Kp59BPLumFhZYufHcU@ANORtGr6dAnYSfiXGMG9rSWyV%2Bw> <201201121438.16674.jhb@freebsd.org> <g1EPx5ZQC20YwBTAuDerf6U7LFc@gTyb322ruC8B7JPI6PUQyZ3XWfA> <20120119172759.GC60214@lor.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Uwl7UQhJk99r8jnw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thu, Jan 19, 2012 at 11:27:59AM -0600, Brooks Davis wrote: > On Fri, Jan 13, 2012 at 11:21:48AM +0400, Eygene Ryabinkin wrote: > > The related topic: in the process of grepping for dhclient within > > /etc, I had found that /etc/netstart still wants to invoke it. But it > > will do a lone '/etc/rc.d/dhclient quietstart' and this will never > > be useful in the current state of dhclient: it will refuse to process > > any commands without the interface being specified. And since we > > have the invocation of /etc/rc.d/netif just two lines above, I think > > that it will be good to remove call to dhclient from /etc/netstart. [...] >=20 > Removing it from /etc/netstart is the right thing to do. Will do it today. > Arguably it should be moved to /libexec since it's not an rc.d > script and simply uses the framework because it had similar needs Well, I fear that some user scripts may rely on the dhclient path to be /etc/rc.d/dhclient, so such a change could lead to the POLA violation. So, all pros and cons of such a change should be carefully weighted. What is the gain from moving it to /libexec apart from avoiding pollution of /etc/rc.d by non-rc.d scripts? It is a good thing to have for the clear design, but having dhclient in /etc/rc.d has no effect on the boot process, since it is marked 'nostart' and it allows people to use 'service dhclient restart $if' without hacking the service to still allow to use this command. We can, of course, move it to /libexec/rc.d/ and add this path to the local_startup, but I doubt that this approach will give any real gain, though I can be missing some important points. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --Uwl7UQhJk99r8jnw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EABEIAAYFAk8ZSpoACgkQFq+eroFS7PsM9QD/TlfxrPer4UoXt/WjC1Ez2qUM z4uWjMpRLGzUCJfzzHoA/jdcmHHjORdPq5NPY2/R/AB07/uZEguSbXZFRRbrTDcl =eaQT -----END PGP SIGNATURE----- --Uwl7UQhJk99r8jnw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7dcvawMgnE9O34bJ7H3SrdYasTs>