Date: Sat, 25 Jun 2016 21:25:48 +0300 From: Ivan Klymenko <fidaj@ukr.net> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r302194 - head/lib/libthr/thread Message-ID: <20160625212548.14057aa1@nonamehost.local> In-Reply-To: <20160625180657.GG38613@kib.kiev.ua> References: <20160625170406.77c79b2e@nonamehost.local> <20160625140529.GW38613@kib.kiev.ua> <20160625171800.50a43746@nonamehost.local> <20160625142915.GX38613@kib.kiev.ua> <20160625175503.7c57d42b@nonamehost.local> <20160625152006.GA38613@kib.kiev.ua> <20160625190346.19a1ef0d@nonamehost.local> <20160625161615.GD38613@kib.kiev.ua> <20160625204317.0aae5c98@nonamehost.local> <20160625180543.GF38613@kib.kiev.ua> <20160625180657.GG38613@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 25 Jun 2016 21:06:57 +0300
Konstantin Belousov <kostikbel@gmail.com> wrote:
> On Sat, Jun 25, 2016 at 09:05:43PM +0300, Konstantin Belousov wrote:
> > On Sat, Jun 25, 2016 at 08:43:17PM +0300, Ivan Klymenko wrote: =20
> > > ./thr_mutex_test
> > > thr_mutex_test: mutex_trylock 2: No error: 0 =20
> >=20
> > Ok, there is a bug in my test, it must use errc(3) and not err(3).
> > Please retest wth the updated code below. But I am sure that you
> > would see EDEADLK (Resource deadlock avoided) error, which means
> > that you have wrong, i.e. unpatched libthr, installed.
> >=20
> > For me, the output is=20
> > sandy% ./pthread_errrecurse
> > sandy% echo $?
> > 0
> > =20
> Err, the updated test.
>=20
> /* $Id: pthread_errrecurse.c,v 1.2 2016/06/25 18:02:54 kostik Exp
> kostik $ */
>=20
> #include <err.h>
> #include <errno.h>
> #include <pthread.h>
>=20
> int
> main(void)
> {
> pthread_mutex_t m;
> pthread_mutexattr_t ma;
> int error;
>=20
> error =3D pthread_mutexattr_init(&ma);
> if (error !=3D 0)
> errc(1, error, "mutexattr_init");
> error =3D pthread_mutexattr_settype(&ma,
> PTHREAD_MUTEX_ADAPTIVE_NP); if (error !=3D 0)
> errc(1, error, "mutexattr_settype");
> error =3D pthread_mutex_init(&m, &ma);
> if (error !=3D 0)
> errc(1, error, "mutex_init");
> error =3D pthread_mutex_trylock(&m);
> if (error !=3D 0)
> errc(1, error, "mutex_trylock 1");
> error =3D pthread_mutex_trylock(&m);
> if (error !=3D EBUSY)
> errc(1, error, "mutex_trylock 2");
> else if (error =3D=3D 0)
> errx(1, "mutex_trylock 2 succeeded");
> return (0);
> }
1. Patched & installed libthr r302195
2. test for other soft:
mousepad=20
GLib (gthread-posix.c): Unexpected error from C library during
'pthread_mutex_trylock': =D0=A3=D0=BD=D0=B8=D0=BA=D0=BD=D1=83=D1=82=D0=BE =
=D0=B2=D0=B7=D0=B0=D1=94=D0=BC=D0=BD=D0=B5 =D0=B1=D0=BB=D0=BE=D0=BA=D1=83=
=D0=B2=D0=B0=D0=BD=D0=BD=D1=8F =D1=80=D0=B5=D1=81=D1=83=D1=80=D1=81=D1=96=
=D0=B2.
Aborting. =D0=90=D0=B2=D0=B0=D1=80=D1=96=D0=B9=D0=BD=D0=B5 =D0=B7=D0=B0=D0=
=B2=D0=B5=D1=80=D1=88=D0=B5=D0=BD=D0=BD=D1=8F(=D0=B7=D0=B0=D0=BF=D0=B8=D1=
=81=D0=B0=D0=BD=D0=BE core)
3.test new ./thr_mutex_test=20
thr_mutex_test: mutex_trylock 2: No error: 0
4. restore patch & install original libthr r302195
5. test for other soft:
mousepad
GLib (gthread-posix.c): Unexpected error from C library during
'pthread_mutex_trylock': =D0=A3=D0=BD=D0=B8=D0=BA=D0=BD=D1=83=D1=82=D0=BE =
=D0=B2=D0=B7=D0=B0=D1=94=D0=BC=D0=BD=D0=B5 =D0=B1=D0=BB=D0=BE=D0=BA=D1=83=
=D0=B2=D0=B0=D0=BD=D0=BD=D1=8F =D1=80=D0=B5=D1=81=D1=83=D1=80=D1=81=D1=96=
=D0=B2.
Aborting. =D0=90=D0=B2=D0=B0=D1=80=D1=96=D0=B9=D0=BD=D0=B5 =D0=B7=D0=B0=D0=
=B2=D0=B5=D1=80=D1=88=D0=B5=D0=BD=D0=BD=D1=8F(=D0=B7=D0=B0=D0=BF=D0=B8=D1=
=81=D0=B0=D0=BD=D0=BE core)
6. test new ./thr_mutex_test=20
thr_mutex_test: mutex_trylock 2: No error: 0
7. restore & install libthr r302191
8. test for other soft:
mousepad - complete run
9. test new ./thr_mutex_test=20
thr_mutex_test: mutex_trylock 2: No error: 0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160625212548.14057aa1>