Date: Fri, 6 Jul 2018 15:43:32 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Kyle Evans <kevans@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336026 - in head: lib/libnv usr.sbin/config Message-ID: <20180706124332.GO5562@kib.kiev.ua> In-Reply-To: <201807061123.w66BNEtb022856@repo.freebsd.org> References: <201807061123.w66BNEtb022856@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 06, 2018 at 11:23:14AM +0000, Kyle Evans wrote: > Author: kevans > Date: Fri Jul 6 11:23:14 2018 > New Revision: 336026 > URL: https://svnweb.freebsd.org/changeset/base/336026 > > Log: > config(8): Fix broken ABI > > r336019 introduced ${SRCTOP}/sys to the include paths in order to pull in a > new sys/{c,}nv.h. This is wrong, because the build tree's ABI isn't > guaranteed to match what's running on the host system. > > Fix instead by removing -I${SRCTOP}/sys and installing the libnv headers > with `make -C lib/libnv includes`... this may or may not get re-worked in > the future so that a userland lib isn't installing includes from sys/. But which libnv the cross-tool config(8) is linked against, the host-provided one ? libnv which exposes the new headers interface would come into existence only for the target. Also, I do not think that you can build this library for cross-tools.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180706124332.GO5562>