Date: Thu, 23 Feb 2017 16:54:30 +0000 (UTC) From: Alan Somers <asomers@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r314150 - head/sys/dev/xen/netback Message-ID: <201702231654.v1NGsU6t062701@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: asomers Date: Thu Feb 23 16:54:30 2017 New Revision: 314150 URL: https://svnweb.freebsd.org/changeset/base/314150 Log: Fix the xnb(4) unit tests One test was inadvertently expecting a bug in the kernel's sscanf implementation circa 2012. I don't know when that bug got fixed. Reported by: royger Reviewed by: royger MFC after: 3 weeks Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D9766 Modified: head/sys/dev/xen/netback/netback_unit_tests.c Modified: head/sys/dev/xen/netback/netback_unit_tests.c ============================================================================== --- head/sys/dev/xen/netback/netback_unit_tests.c Thu Feb 23 16:42:48 2017 (r314149) +++ head/sys/dev/xen/netback/netback_unit_tests.c Thu Feb 23 16:54:30 2017 (r314150) @@ -2528,7 +2528,7 @@ xnb_sscanf_hhn(char *buffer, size_t bufl XNB_ASSERT(sscanf(mystr, "000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f" "202122232425262728292a2b2c2d2e2f303132333435363738393a3b3c3d3e3f" - "404142434445464748494a4b4c4d4e4f%hhn", &dest[4]) == 1); + "404142434445464748494a4b4c4d4e4f%hhn", &dest[4]) == 0); for (i = 0; i < 12; i++) XNB_ASSERT(dest[i] == (i == 4 ? 160 : 'X')); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702231654.v1NGsU6t062701>