Date: Sat, 30 Jun 2001 03:11:47 +0900 From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> To: acpi-jp@jp.freebsd.org, msmith@freebsd.org Cc: current@freebsd.org Subject: Re: [acpi-jp 1150] HEADS UP: ACPI update - thermal management Message-ID: <20010630031147Q.iwasaki@jp.FreeBSD.org> In-Reply-To: <200106280635.f5S6Z7w07241@mass.dis.org> References: <200106280635.f5S6Z7w07241@mass.dis.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, mike.
> This is just a heads-up to let folks know that I've committed some early
> code to handle thermal management under ACPI. This should DTRT with
> active cooling (fans, etc.). It won't help with passive cooling yet (we
> need to sort out the processor device control first), and it may well
> have problems (there are places where the specification is vague about
> what should be in the namespace and my ability to test these options is
> limited).
I tested this a bit and noticed following messages.
unknown: error fetching current temperature
I think that notify handler got wrong parameter, device_t not softc.
Here is the fix for it.
Index: acpi_thermal.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/acpica/acpi_thermal.c,v
retrieving revision 1.8
diff -u -r1.8 acpi_thermal.c
--- acpi_thermal.c 2001/06/28 06:17:16 1.8
+++ acpi_thermal.c 2001/06/29 17:48:14
@@ -151,7 +151,7 @@
* Register for any Notify events sent to this zone.
*/
AcpiInstallNotifyHandler(sc->tz_handle, ACPI_DEVICE_NOTIFY,
- acpi_tz_notify_handler, dev);
+ acpi_tz_notify_handler, sc);
BTW, how about sysctl interface for ACPI thermal zone?
At least the representative temperature would be useful for users.
Thanks
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010630031147Q.iwasaki>