Date: Fri, 16 May 2003 19:40:40 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha machdep.c src/sys/alpha/osf1 osf1_signal.c src/sys/amd64/amd64 machdep.c src/sys/compat/linprocfs linprocfs.c src/sys/compat/svr4 svr4_filio.c svr4_misc.c src/sys/i Message-ID: <20030516192737.E11918@gamplex.bde.org> In-Reply-To: <XFMail.20030515160450.jhb@FreeBSD.org> References: <XFMail.20030515160450.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 15 May 2003, John Baldwin wrote: > On 15-May-2003 Bruce Evans wrote: > > On Wed, 14 May 2003, John Baldwin wrote: > > > >> On 14-May-2003 Kimura Fuyuki wrote: > >> > At Tue, 13 May 2003 13:36:02 -0700 (PDT), > >> > John Baldwin <jhb@freebsd.org> wrote: > >> >> 1.61 +23 -4 src/sys/sys/signalvar.h > >> > > >> > There seems to be missing #include <sys/queue.h>. > >> > >> Yes. :( I wonder if it shouldn't be in sys/_lock.h > >> instead. > > > > Less than it should include <sys/types.h> for its use of u_int (i.e., > > it shouldn't). > > Hmm, I can fix it to use unsigned instead if that is preferred: There's not much point, since other typedefs are needed (e.g., uintptr_t in <sys/_mutex.h>. Also, `unsigned' is messes up the formatting in <sys/_lock.h>. The rule for when to use u_int vs. `unsigned' is more or less "always use u_int" in kernel only [parts of] headers; never use it in application headers". Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030516192737.E11918>