Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 Aug 2010 19:27:44 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Rui Paulo <rpaulo@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r211553 - head/sys/cddl/compat/opensolaris/kern
Message-ID:  <20100828172744.GJ2077@garage.freebsd.pl>
In-Reply-To: <201008211141.o7LBfWdv067923@svn.freebsd.org>
References:  <201008211141.o7LBfWdv067923@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--k1BdFSKqAqVdu8k/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Aug 21, 2010 at 11:41:32AM +0000, Rui Paulo wrote:
> Author: rpaulo
> Date: Sat Aug 21 11:41:32 2010
> New Revision: 211553
> URL: http://svn.freebsd.org/changeset/base/211553
>=20
> Log:
>   Add sysname to struct opensolaris_utsname. This is needed by one DTrace
>   test.
>  =20
>   Sponsored by:	The FreeBSD Foundation
>=20
> Modified:
>   head/sys/cddl/compat/opensolaris/kern/opensolaris_misc.c
>=20
> Modified: head/sys/cddl/compat/opensolaris/kern/opensolaris_misc.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/cddl/compat/opensolaris/kern/opensolaris_misc.c	Sat Aug 21 1=
1:33:49 2010	(r211552)
> +++ head/sys/cddl/compat/opensolaris/kern/opensolaris_misc.c	Sat Aug 21 1=
1:41:32 2010	(r211553)
> @@ -38,7 +38,8 @@ __FBSDID("$FreeBSD$");
>  char hw_serial[11] =3D "0";
> =20
>  struct opensolaris_utsname utsname =3D {
> -	.nodename =3D "unset"
> +	.nodename =3D "unset",
> +	.sysname  =3D "SunOS"

This collides with the changes I have in perforce. Could you take a look at:

	//depot/user/pjd/zfs/sys/cddl/compat/opensolaris/kern/opensolaris_misc.c
	//depot/user/pjd/zfs/sys/cddl/compat/opensolaris/sys/misc.h

I'd prefer sysname to say FreeBSD on FreeBSD, rather than SunOS.
I see it is being used in one DTrace test. Changing 'tst.str.d.out' to
expect "FreeBSD" instead of "SunOS" is ok?

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--k1BdFSKqAqVdu8k/
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iEYEARECAAYFAkx5Rw8ACgkQForvXbEpPzQYdACeOAyXMTQ1ZBkLlacuyC7tJMw5
h3IAoNLl/v2YI/FFxGbemxssRdODiltB
=pXCv
-----END PGP SIGNATURE-----

--k1BdFSKqAqVdu8k/--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100828172744.GJ2077>