Date: 15 Mar 2002 19:17:32 +0100 From: Dag-Erling Smorgrav <des@ofug.org> To: obrien@FreeBSD.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_softdep.c Message-ID: <xzppu25puf7.fsf@flood.ping.uio.no> In-Reply-To: <20020315095447.C44160@dragon.nuxi.com> References: <200203150406.g2F46Bw06312@freefall.freebsd.org> <xzpofhprj9v.fsf@flood.ping.uio.no> <20020315095447.C44160@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"David O'Brien" <obrien@FreeBSD.org> writes: > error = 0; > > at the beginning of the function is obfuscatation?? Hey, I'm not attacking your patch; I was aware of the problem and considered committing the exact same patch myself. I'm just annoyed that gcc isn't able to determine that the loop always runs at least once. But maybe I'm wishing for the moon... Anyway, I was bitching at gcc, not at you. Sorry if that wasn't clear. > At the companies > I've worked at, local variables were _required_ to be initialized after > their definition. Most of the time, this is a good idea, but sometimes it can hide real errors; like forgetting to set error before returning when an error actually occurs, so the caller thinks you succeeded. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzppu25puf7.fsf>