Date: Sun, 10 Jun 2012 15:27:21 +0200 From: Fabian Keil <freebsd-listen@fabiankeil.de> To: Andriy Gapon <avg@FreeBSD.org> Cc: freebsd-hackers@freebsd.org Subject: Re: decoding of multi-byte nops in dtrace Message-ID: <20120610152721.3b627896@fabiankeil.de> In-Reply-To: <4FD490D5.1070207@FreeBSD.org> References: <4FD490D5.1070207@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/0505RVOCRjn_Zz7F5zv4atD Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Andriy Gapon <avg@FreeBSD.org> wrote: > It seems that the $subj is missing :-) > In my environment that causes many functions to not have fbt return probe, > because function body decoding fails before 'ret' is found. >=20 > Here is my attempt at fixing the problem: > http://people.freebsd.org/~avg/fbt-nop.patch > Reviews and suggestions are welcome. The patch seems to reduce the number of missing fbt return probes by about 50% for me. Without the patch: fk@r500 /usr/src $sudo dtrace -ln fbt::: | grep -c entry 23395 fk@r500 /usr/src $sudo dtrace -ln fbt::: | grep -c return 16739 With the patch (and updated kernel sources): fk@r500 ~ $sudo dtrace -ln fbt::: | grep -c entry 23409 fk@r500 ~ $sudo dtrace -ln fbt::: | grep -c return 19879 Thanks Fabian --Sig_/0505RVOCRjn_Zz7F5zv4atD Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk/UoL4ACgkQBYqIVf93VJ2+wQCfVfvCivnU3Dn/iJZcivJ2JDeD C9UAnR+zvUV5C/VekYP3obj07yJhSSEK =k1kq -----END PGP SIGNATURE----- --Sig_/0505RVOCRjn_Zz7F5zv4atD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120610152721.3b627896>