Date: Wed, 16 Nov 2005 13:23:09 +0100 (CET) From: Pawel Wieleba <P.Wieleba@iem.pw.edu.pl> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/89117: [PATCH] audio/sox; enable OPTIONS; configure KNOBS via dialog Message-ID: <20051116122310.0291327509@amper.iem.pw.edu.pl> Resent-Message-ID: <200511161230.jAGCUHmV060068@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 89117
>Category: ports
>Synopsis: [PATCH] audio/sox; enable OPTIONS; configure KNOBS via dialog
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Wed Nov 16 12:30:16 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Pawel Wieleba
>Release: FreeBSD 7.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD srv 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Mon Oct 31 17:22:48 CET 2005 root@srv:/usr/src/sys/i386/compile/SRV i386
>Description:
This port doesn't support configuration via dialog (doesn't support options).
>How-To-Repeat:
"make config" is not supported
>Fix:
I've added OPTIONS support to audio/sox port in the patch:
--- Makefile.diff begins here ---
--- Makefile-OLD Thu Oct 6 05:40:12 2005
+++ Makefile Wed Nov 16 12:17:23 2005
@@ -21,6 +21,10 @@
GNU_CONFIGURE= yes
MAKE_ENV= PLAY_SUPPORT=1
+OPTIONS= LAME "Enable mp3 encoding with LAME" off \
+ MAD "Enable mp3 decoding with MAD" off \
+ VORBIS "Enable Ogg Vorbis support" off
+
.include <bsd.port.pre.mk>
.if exists(${LOCALBASE}/lib/libmp3lame.so.0)
@@ -60,17 +64,6 @@
LIB_DEPENDS+= mad.2:${PORTSDIR}/audio/libmad
.else
CONFIGURE_ARGS+= --disable-mad
-.endif
-
-pre-fetch:
-.if !defined(WITH_LAME)
- @${ECHO_MSG} "You can enable mp3 encoding by defining WITH_LAME."
-.endif
-.if !defined(WITH_MAD)
- @${ECHO_MSG} "You can enable mp3 decoding by defining WITH_MAD."
-.endif
-.if !defined(WITH_VORBIS)
- @${ECHO_MSG} "You can enable Ogg Vorbis support by defining WITH_VORBIS."
.endif
.include <bsd.port.post.mk>
--- Makefile.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051116122310.0291327509>