Date: Mon, 21 Jun 2010 15:05:44 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar <marcel@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r209358 - head/cddl/contrib/opensolaris/lib/libdtrace/common Message-ID: <20100621150544.094de36a@kan.dnsalias.net> In-Reply-To: <20100622041935.J44301@delplex.bde.org> References: <201006200034.o5K0Y6xl041024@svn.freebsd.org> <20100622024652.C43995@delplex.bde.org> <20100621133340.7501713b@kan.dnsalias.net> <20100622041935.J44301@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/DjS3c48Jj_20RNX43UHywwG Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 22 Jun 2010 04:30:12 +1000 (EST) Bruce Evans <brde@optusnet.com.au> wrote: > On Mon, 21 Jun 2010, Alexander Kabaev wrote: >=20 > > On Tue, 22 Jun 2010 03:22:40 +1000 (EST) > > Bruce Evans <brde@optusnet.com.au> wrote: > > <SKIP> > > > > DTrace _does_ try to unput EOF though and apparently gets away with > > it on Solaris, so while yor version is correct, it is also useless. >=20 > Do you mean that it tries to unput EOF as an int (not obtained from a > char), and that that must fail and not unput ((unsigned char)EOF)? > Then the current version is still broken on platforms with chars > signed, since when it tries to unput a char with value EOF, that will > fail and not unput ((unsigned char)<char's value>). Correct, but chances of valid DTrace script having 0xff character in them is pretty much nonexistent, so I let that slide rather than pushing more changes into externally maintained code. To be absolutely correct, I think, we need to declare unput() as inline/static taking int argument and make sure that we invoke it as unput((unsigned char)*q) every time q is declared as char *. --=20 Alexander Kabaev --Sig_/DjS3c48Jj_20RNX43UHywwG Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iD8DBQFMH7gLQ6z1jMm+XZYRAnInAJ428KTLRLk/JrBSu8yseo+VTYTKXACcC3a5 J2Xif5/rD3vIGKd6FLcVpYk= =uVbI -----END PGP SIGNATURE----- --Sig_/DjS3c48Jj_20RNX43UHywwG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100621150544.094de36a>