Date: Sat, 28 Jun 2025 13:12:54 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Michael Tuexen <tuexen@freebsd.org> Cc: Charlie Li <vishwin@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 89f6eb0a61cb - main - tcp: restrict the contents of tcp_timer.h to the kernel context Message-ID: <aGBMxrHbyEPc59a7@cell.glebi.us> In-Reply-To: <BDD29F9A-1254-4631-B804-E10A523A8CC4@FreeBSD.org> References: <202506261609.55QG9odv049208@gitrepo.freebsd.org> <b01738c4-a780-4553-bb6e-718e9fba18cd@freebsd.org> <BDD29F9A-1254-4631-B804-E10A523A8CC4@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 28, 2025 at 04:04:33AM +0200, Michael Tuexen wrote: M> >> + M> >> /* M> >> * The TCPT_REXMT timer is used to force retransmissions. M> >> * The TCP has the TCPT_REXMT timer set whenever segments M> >> @@ -133,8 +135,6 @@ M> >> (tv) = (tvmax); \ M> >> } while(0) M> >> -#ifdef _KERNEL M> >> - M> >> #define TP_KEEPINIT(tp) ((tp)->t_keepinit ? (tp)->t_keepinit : tcp_keepinit) M> >> #define TP_KEEPIDLE(tp) ((tp)->t_keepidle ? (tp)->t_keepidle : tcp_keepidle) M> >> #define TP_KEEPINTVL(tp) ((tp)->t_keepintvl ? (tp)->t_keepintvl : tcp_keepintvl) M> > This broke net-mgmt/net-snmp, which uses at least TCPTV_MIN and TCPTV_REXMTMAX. M> Hi Charlie, M> M> why is net-mgmt/net-snmp interested in the default value of the sysctl variables M> net.inet.tcp.rexmit_min and net.inet.tcp.tcp_rexmit_max and not in the current M> value of these sysctl variables? This does not make sense to me... I'll try to find some time to make a push request for them. We already accumulates some hot fixes in the port, now this adds up. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aGBMxrHbyEPc59a7>