Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 2 Feb 2003 00:48:57 +0000
From:      Andrew Mishchenko <andrew@driftin.net>
To:        Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc:        current@FreeBSD.ORG
Subject:   Re: Style fixups for proc.h
Message-ID:  <20030202004857.GB6673@driftin.net>
In-Reply-To: <20030201235943.GA66200@troutmask.apl.washington.edu>
References:  <200302012246.h11MkEaX028068@grimreaper.grondar.org> <Pine.BSF.4.21.0302011502090.55342-100000@InterJet.elischer.org> <20030201235943.GA66200@troutmask.apl.washington.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat 01 Feb, Steve Kargl wrote:
> From: Steve Kargl <sgk@troutmask.apl.washington.edu>
> To: Julian Elischer <julian@elischer.org>
> Cc: Mark Murray <mark@grondar.org>, julian@FreeBSD.ORG, current@FreeBSD.ORG
> Subject: Re: Style fixups for proc.h
> 
> On Sat, Feb 01, 2003 at 03:04:32PM -0800, Julian Elischer wrote:
> > I don't know about the protection with a '_'.
> > 
> > It's not standard and usually the name matches that used in the actual
> > function.
> > 
> > It's certainly not part of style(9) that I've ever noticed
> > and it's generally noy done that way.. is there a move to do this on all
> > the other files?
> > 
> 
> man 9 style
> 
>      In header files visible to userland applications, prototypes that are
>      visible must use either ``protected'' names (ones beginning with an
>      underscore) or no names with the types.  It is preferable to use pro-
>      tected names.  E.g., use:
> 
>      void    function(int);
> 
>      or:
> 
>      void    function(int _fd);
> 

Since having actual names in can be helpful if the names are relevant, but
having dozens of *_p floating all over the place is not more easily readable,
why not leave names out completely when they are not relevant and protect with
the underscore when they are?  This agrees with style(9).

Andrew

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030202004857.GB6673>