Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 5 Dec 2019 10:05:10 -0800
From:      Enji Cooper <yaneurabeya@gmail.com>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        Kubilay Kocak <koobs@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r355407 - head/sys/fs/tmpfs
Message-ID:  <80859C2E-1973-4E89-BAD2-5586CC683504@gmail.com>
In-Reply-To: <20191205133544.GE2744@kib.kiev.ua>
References:  <20191205133544.GE2744@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help


> On Dec 5, 2019, at 05:36, Konstantin Belousov <kostikbel@gmail.com> wrote:

...

>> Could you elaborate on the why/rationale?
>> 
>> Is there memory wastage/duplication, bug(s), performance or 
>> development/maintenance benefit?
> Each mount/unmount of tmpfs created and destroyed two zones, as it is
> easy to see from the patch.

Commit messages should provide helpful summaries of changes. Having to look at and understand the patch requires domain knowledge which the reader may or may not have. Kubilay’s request seems valid to me.

-Enji


Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?80859C2E-1973-4E89-BAD2-5586CC683504>