Date: Thu, 4 May 2006 15:39:43 +0200 From: Jean-Yves Lefort <jylefort@FreeBSD.org> To: pav@FreeBSD.org Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/astro/celestia Makefile distinfo pkg-message.gnome pkg-plist ports/astro/celestia/files patch-config.h.in patch-src_celestia_Makefile.in patch-src_celestia_gtkmain.cpp patch-src_celutil_resmanager.h patch-src_celutil_util.h Message-ID: <20060504153943.64a39678.jylefort@FreeBSD.org> In-Reply-To: <1146749152.18447.14.camel@pav.hide.vol.cz> References: <200605041238.k44CcbRf005669@repoman.freebsd.org> <1146746599.18447.11.camel@pav.hide.vol.cz> <20060504151740.62d5d719.jylefort@FreeBSD.org> <1146749152.18447.14.camel@pav.hide.vol.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, 04 May 2006 15:25:52 +0200 Pav Lucistnik <pav@FreeBSD.org> wrote: > Jean-Yves Lefort píše v čt 04. 05. 2006 v 15:17 +0200: > > On Thu, 04 May 2006 14:43:19 +0200 > > Pav Lucistnik <pav@FreeBSD.org> wrote: > > > > > Jean-Yves Lefort píše v čt 04. 05. 2006 v 12:38 +0000: > > > > jylefort 2006-05-04 12:38:37 UTC > > > > > > > > FreeBSD ports repository > > > > > > > > Modified files: > > > > astro/celestia Makefile distinfo > > > > Added files: > > > > astro/celestia pkg-message.gnome pkg-plist > > > > astro/celestia/files patch-config.h.in > > > > patch-src_celestia_Makefile.in > > > > patch-src_celutil_util.h > > > > Removed files: > > > > astro/celestia/files patch-src_celestia_gtkmain.cpp > > > > patch-src_celutil_resmanager.h > > > > > > > - Do not use OPTIONS for the mutually exclusive UI choices, use > > > > > > Your usage of OPTIONS is incorrect. For default on options, you have to > > > test WITHOUT_* variable. Please refer for more details to > > > http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html > > > > Why? > > When you bypass OPTIONS completely (using BATCH or PACKAGE_BUILD), no > OPTIONS related variables are created. > > Your tests must do the "default" thing when no variables were created. > Otherwise pointyhat packages will have non-default properties. > > At the moment, no WITH_LUA nor WITHOUT_LUA variable is created when > using BATCH, and your test > > .if WITH_LUA > > will fail. Such package will end without Lua support, even when you > specified the option to default to "on". Apparently the handbook is outdated: $ make -V WITH_LUA $ make -V WITH_LUA BATCH=yes true $ make -V WITH_LUA PACKAGE_BUILDING=yes true cf. bsd.port.mk: . if defined(PACKAGE_BUILDING) || (defined(BATCH) && !exists(${_OPTIONSFILE})) -- Jean-Yves Lefort jylefort@FreeBSD.org http://lefort.be.eu.org/ [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEWgQfyzD7UaO4AGoRAmoKAJ95GTqcX8Ye2KkhFOjqVuG0BP55AwCff/1B 7OoIumX0PGwcd22ooCb1a48= =2OzL -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060504153943.64a39678.jylefort>