Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Oct 2015 08:42:02 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r289700 - in head/sys/compat/linuxkpi: . common common/include common/include/asm common/include/linux common/src
Message-ID:  <5627B24A.4010905@FreeBSD.org>
In-Reply-To: <5627B1B5.30607@selasky.org>
References:  <201510211501.t9LF1phM000793@repo.freebsd.org> <5627AF01.8070501@FreeBSD.org> <5627B1B5.30607@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
On 10/21/2015 8:39 AM, Hans Petter Selasky wrote:
> On 10/21/15 17:28, Bryan Drewery wrote:
>> On 10/21/2015 8:01 AM, Hans Petter Selasky wrote:
>>> Author: hselasky
>>> Date: Wed Oct 21 15:01:51 2015
>>> New Revision: 289700
>>> URL: https://svnweb.freebsd.org/changeset/base/289700
>>>
>>> Log:
>>>    Start process of moving the LinuxKPI into the default kernel build by
>>>    creating an empty directory tree.
>>>
>>>    Sponsored by:    Mellanox Technologies
>>>
>>> Added:
>>>    head/sys/compat/linuxkpi/
>>>    head/sys/compat/linuxkpi/common/
>>>    head/sys/compat/linuxkpi/common/include/
>>>    head/sys/compat/linuxkpi/common/include/asm/
>>>    head/sys/compat/linuxkpi/common/include/linux/
>>>    head/sys/compat/linuxkpi/common/src/
>>>
>>
>> This makes me think a branch should be used instead.
>>
> 
> Most of what will be done is "svn mv" out of "sys/ofed" and changing
> some include paths in sys/modules and sys/conf . Can you explain why you
> think a branch is required ?

Because you're splitting commits up that should otherwise not be split
up. There's no reason to commit empty directories before a 'svn mv' into
them.


-- 
Regards,
Bryan Drewery


[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJWJ7JLAAoJEDXXcbtuRpfPzd0H/A40JZhouq+EBVbcGy8lDiK2
5tV7Y5pmpyZvzYuSLhTqYthMgGTc9WHo0RY3SBV5LobBwYfV2NkC8LlP0fVJPbFx
IinhzDPsHjTlkxRTr09uWZaXw9Dhg7n1+9wJmm8xlW0ejWfKSOVk/q1UcKI2AuZD
2dHtDB8aIlGsVRl8BRUEM61hT9J05A00W6697zJbKWGmQi7kGQbYChiPTLFaKaJV
sFU9cgTkoYDQwWvK3pDA8+z8omK04FK//NRUkn8idRydtXiqhn0cfAAFAuoyhoyZ
4zDYhxucxivN4oEMrW0NcN6DFf2m/Bkfs63SMQ97HYbIBWqwuY3jfYY5c5krp5Q=
=kNk+
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5627B24A.4010905>