Date: Sun, 22 Sep 2024 11:01:05 -0700 From: Mark Millard <marklmi@yahoo.com> To: dev-commits-src-main@freebsd.org, Warner Losh <imp@bsdimp.com>, a.munoz3327@gmail.com Subject: git: 85918beb387f - main - intrng: Add support for multiple interrupt roots Message-ID: <1B971CC2-DD1F-488B-A80B-98EF29256D50@yahoo.com> References: <1B971CC2-DD1F-488B-A80B-98EF29256D50.ref@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
From: Warner Losh <imp_at_FreeBSD.org> wrote on Date: Sun, 22 Sep 2024 13:19:21 UTC : > The branch main has been updated by imp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D85918beb387f179abc93a6c613801fb9= 761ff1e2 >=20 > commit 85918beb387f179abc93a6c613801fb9761ff1e2 > Author: Ayrton Munoz <a.munoz3327@gmail.com> > AuthorDate: 2024-07-21 18:10:20 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2024-09-22 13:18:34 +0000 >=20 > intrng: Add support for multiple interrupt roots >=20 > Different types of interrupts may require using different exception > vectors so this commit adds support multiple interrupt roots to handle > these cases. Archs may opt-in to multiple interrupt roots by defining > INTR_ROOT_NUM as the number of roots in their intr.h. Based off > https://reviews.freebsd.org/D40161. >=20 > Signed-off-by: Ayrton Munoz <a.munoz3327@gmail.com> > Co-authored-by: Kyle Evans <kevans@FreeBSD.org> > Co-authored-by: Andrew Turner <andrew@FreeBSD.org> > Reviewed-by: imp,mmel,mhorne > Pull-Request: https://github.com/freebsd/freebsd-src/pull/1363 . . . > +/* > + * Archs may define multiple roots with INTR_ROOT_NUM to support = different kinds > + * of interrupts (e.g. arm64 FIQs which use a different exception = vector than > + * IRQs). > + */ > +#if !defined(INTR_ROOT_NUM) > +#define INTR_ROOT_NUM 1 > +#endif > + . . . When I was reading the: https://github.com/freebsd/freebsd-src/pull/1363 conversation I saw: -#define INTR_ROOT_NUM 2 +#define INTR_ROOT_COUNT 2 and related discussion with 2 thumbs up, including one by ayrtonm. A similar point goes for: -void *arg, uint32_t rootnum) +void *arg, uint32_t roottype) with another ayrtonm thumbs up at the end. (I've not checked if there are more distinctions.) Such leaves me wondering if what was committed was actually the final intended code: Is it? =3D=3D=3D Mark Millard marklmi at yahoo.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1B971CC2-DD1F-488B-A80B-98EF29256D50>