Date: Tue, 23 Oct 2012 11:55:49 +0200 From: Jilles Tjoelker <jilles@stack.nl> To: Peter Grehan <grehan@freebsd.org> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r241744 - projects/bhyve/usr.sbin/bhyve Message-ID: <20121023095549.GA27951@stack.nl> In-Reply-To: <5085D433.4020101@freebsd.org> References: <201210191811.q9JIBIQu049356@svn.freebsd.org> <20121021121006.GA96141@stack.nl> <5085D433.4020101@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 22, 2012 at 05:18:11PM -0600, Peter Grehan wrote: > > Case 4 looks wrong. A 32-bit write clears the top 32 bits of the > > register instead of preserving them. > Yep, you're right. How about: > > + case 4: > > + val = (reg & ~0xffffffffUL) | (operand & 0xffffffffUL); > > + break; I think you mean: val = operand & 0xffffffffUL; Right? -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121023095549.GA27951>