Date: Fri, 14 Sep 2012 14:42:48 +0100 From: Attilio Rao <attilio@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240475 - in head/sys: dev/hwpmc kern Message-ID: <CAJ-FndCrFK9no1-J-JaEPANhK6Pj-tibMfLr3xiJ0JW8oOL3_w@mail.gmail.com> In-Reply-To: <20120914133833.GC37286@deviant.kiev.zoral.com.ua> References: <201209132226.q8DMQMFC088169@svn.freebsd.org> <20120914042031.GZ37286@deviant.kiev.zoral.com.ua> <CAJ-FndCHqpnLpaf12ASdnEtcY%2BP%2BBw-hb6zKz7MQrRHJf4kVBw@mail.gmail.com> <20120914133833.GC37286@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 14, 2012 at 2:38 PM, Konstantin Belousov <kostikbel@gmail.com> wrote: > On Fri, Sep 14, 2012 at 01:03:13PM +0100, Attilio Rao wrote: >> On 9/14/12, Konstantin Belousov <kostikbel@gmail.com> wrote: >> > On Thu, Sep 13, 2012 at 10:26:22PM +0000, Attilio Rao wrote: >> >> Author: attilio >> >> Date: Thu Sep 13 22:26:22 2012 >> >> New Revision: 240475 >> >> URL: http://svn.freebsd.org/changeset/base/240475 >> >> >> >> Log: >> >> Remove all the checks on curthread != NULL with the exception of some >> >> MD >> >> trap checks (eg. printtrap()). >> >> >> >> Generally this check is not needed anymore, as there is not a >> >> legitimate >> >> case where curthread != NULL, after pcpu 0 area has been properly >> >> initialized. >> > I do not disagree with the patch, but I do with this statement. >> > During the AP startup, there is indeed a window while curthread is NULL. >> > Unfortunately, trying to panic there is worse then not panic. >> >> Yes and why do you disagree then? That is what I wanted to say -- >> before pcpu->curthread is initialized you can get curthread == NULL. > > I disagree with the statement that curthread is always non-NULL after pcpu 0 > area has been initialized. Ah, I understand what you mean, the "0" part is wrong really, it is any pcpu area infact. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndCrFK9no1-J-JaEPANhK6Pj-tibMfLr3xiJ0JW8oOL3_w>