Date: Sat, 8 Jan 2005 15:46:06 +0000 (UTC) From: Xin LI <delphij@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/usr.sbin/fdcontrol Makefile fdcontrol.c src/usr.sbin/fdformat Makefile src/usr.sbin/fdread Makefile fdread.c fdutil.c src/usr.sbin/fdwrite Makefile fdwrite.c Message-ID: <200501081546.j08Fk6ZF076356@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
delphij 2005-01-08 15:46:06 UTC
FreeBSD src repository
Modified files:
usr.sbin/fdcontrol Makefile fdcontrol.c
usr.sbin/fdformat Makefile
usr.sbin/fdread Makefile fdread.c fdutil.c
usr.sbin/fdwrite Makefile fdwrite.c
Log:
Cleanup usr.sbin/fd* so they can compile under WARNS=6.
fdcontrol/fdcontrol.c:
- Add const constraint to an intermediate value
which is not supposed to be changed elsewhere.
fdread/fdread.c:
- Use _devname in favor of devname to avoid name
conflicit.
- -1 is less than any positive number so in order
to get the block to function, we should get the
block a little earlier.
- Cast to remove signed when we are sure that a
return value is positive, or is compared with
an positive number (tracknumber of a floppy
disk is not likely to have UINT_MAX/2 anyway)
fdread/fdutil.c:
- Use more specific initializer
fdwrite/fdwrite.c:
- Use static on format_track since it's not
referenced in other places.
- Use const char* to represent string constant.
Bump WARNS accordingly.
Revision Changes Path
1.12 +1 -1 src/usr.sbin/fdcontrol/Makefile
1.13 +1 -1 src/usr.sbin/fdcontrol/fdcontrol.c
1.13 +1 -1 src/usr.sbin/fdformat/Makefile
1.5 +2 -0 src/usr.sbin/fdread/Makefile
1.6 +22 -22 src/usr.sbin/fdread/fdread.c
1.8 +7 -7 src/usr.sbin/fdread/fdutil.c
1.11 +1 -0 src/usr.sbin/fdwrite/Makefile
1.15 +5 -4 src/usr.sbin/fdwrite/fdwrite.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200501081546.j08Fk6ZF076356>