Date: Thu, 14 Mar 2019 22:24:21 -0700 From: Conrad Meyer <cem@freebsd.org> To: Andrew Thompson <andy@fud.org.nz> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r345171 - head/usr.sbin/bhyve Message-ID: <CAG6CVpVYyWywKFtqtgayghkrEptmDEP3dm%2BwWE0t7MDqyHXvUw@mail.gmail.com> In-Reply-To: <CAFAOGNTT_ZKCe1zs2XN6H7r-G2E%2BU77WUOrutfWshDNGOR36bQ@mail.gmail.com> References: <201903150211.x2F2BSai079898@repo.freebsd.org> <CAFAOGNTT_ZKCe1zs2XN6H7r-G2E%2BU77WUOrutfWshDNGOR36bQ@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Thu, Mar 14, 2019 at 8:06 PM Andrew Thompson <andy@fud.org.nz> wrote: > > On Fri, 15 Mar 2019 at 15:11, Chuck Tuffli <chuck@freebsd.org> wrote: >> bzero(&pciecap, sizeof(pciecap)); ... >> + pciecap.dev_capabilities = PCIEM_CAP_ROLE_ERR_RPT; > > If the message you say 'set the bit' but you are overwriting the whole variable, is this intended? Looks like it was zero before. So yeah, it sets the bit.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpVYyWywKFtqtgayghkrEptmDEP3dm%2BwWE0t7MDqyHXvUw>