Date: Wed, 14 Jan 2026 11:57:10 -0700 From: Warner Losh <imp@bsdimp.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Ed Maste <emaste@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7f8b4db9e001 - main - github: Add more context to pull requests Message-ID: <CANCZdfoU1RZh=YAy5YrKjqN5XMHOacBaL_vAfFJYUSJfMA9XMQ@mail.gmail.com> In-Reply-To: <DBEC9EBD-F837-4FDB-8EF7-AE78E2D69462@freebsd.org> References: <6964a4b0.3d7cb.74aa5260@gitrepo.freebsd.org> <CAPyFy2Df_70OPuYM4_2k7mbBpvBrhS1%2BeEFm_i0Pb0Q1ckHEwg@mail.gmail.com> <CANCZdfrcFnE-J_6gsKgxpWDu1jjScYXpDTqW%2BfvNTpMrKZp58A@mail.gmail.com> <DBEC9EBD-F837-4FDB-8EF7-AE78E2D69462@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Jan 14, 2026 at 11:22 AM Jessica Clarke <jrtc27@freebsd.org> wrote: > On 14 Jan 2026, at 18:16, Warner Losh <imp@bsdimp.com> wrote: > > On Wed, Jan 14, 2026 at 11:12 AM Ed Maste <emaste@freebsd.org> wrote: > >> On Mon, 12 Jan 2026 at 02:37, Warner Losh <imp@freebsd.org> wrote: > >> > > >> > The branch main has been updated by imp: > >> > > >> > URL: > https://cgit.FreeBSD.org/src/commit/?id=7f8b4db9e001d94974a081e5fd58c4f3994429cb > >> > > >> > commit 7f8b4db9e001d94974a081e5fd58c4f3994429cb > >> > Author: Warner Losh <imp@FreeBSD.org> > >> > AuthorDate: 2026-01-10 16:20:20 +0000 > >> > Commit: Warner Losh <imp@FreeBSD.org> > >> > CommitDate: 2026-01-12 07:18:11 +0000 > >> > > >> > github: Add more context to pull requests > >> > > >> > Add code to fetch and decode CODEOWNERS and automatically @ > people in > >> > the review. > >> > >> Does this not just duplicate existing GitHub functionality; it should > >> be automatically assigning reviewers to a pull request based on > >> CODEOWNERS AFAICT. > > > > No. It's not doing that right now at all. That's why I added it. Maybe > there's a simpler way, but it wasn't tagging people automatically. > > Only users with write permission for the GitHub repo work. > What I've done? Or CODEOWNERS? It works for me, but I'm extra special in github land. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Wed, Jan 14, 2026 at 11:22 AM Jessica Clarke <<a href="mailto:jrtc27@freebsd.org">jrtc27@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 14 Jan 2026, at 18:16, Warner Losh <<a href="mailto:imp@bsdimp.com" target="_blank">imp@bsdimp.com</a>> wrote:<br> > On Wed, Jan 14, 2026 at 11:12 AM Ed Maste <<a href="mailto:emaste@freebsd.org" target="_blank">emaste@freebsd.org</a>> wrote:<br> >> On Mon, 12 Jan 2026 at 02:37, Warner Losh <<a href="mailto:imp@freebsd.org" target="_blank">imp@freebsd.org</a>> wrote:<br> >> ><br> >> > The branch main has been updated by imp:<br> >> ><br> >> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=7f8b4db9e001d94974a081e5fd58c4f3994429cb" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=7f8b4db9e001d94974a081e5fd58c4f3994429cb</a><br>; >> ><br> >> > commit 7f8b4db9e001d94974a081e5fd58c4f3994429cb<br> >> > Author: Warner Losh <imp@FreeBSD.org><br> >> > AuthorDate: 2026-01-10 16:20:20 +0000<br> >> > Commit: Warner Losh <imp@FreeBSD.org><br> >> > CommitDate: 2026-01-12 07:18:11 +0000<br> >> ><br> >> > github: Add more context to pull requests<br> >> ><br> >> > Add code to fetch and decode CODEOWNERS and automatically @ people in<br> >> > the review.<br> >> <br> >> Does this not just duplicate existing GitHub functionality; it should<br> >> be automatically assigning reviewers to a pull request based on<br> >> CODEOWNERS AFAICT.<br> > <br> > No. It's not doing that right now at all. That's why I added it. Maybe there's a simpler way, but it wasn't tagging people automatically.<br> <br> Only users with write permission for the GitHub repo work.<br></blockquote><div><br></div><div>What I've done? Or CODEOWNERS? It works for me, but I'm extra special in github land.</div><div><br></div><div>Warner </div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoU1RZh=YAy5YrKjqN5XMHOacBaL_vAfFJYUSJfMA9XMQ>