Date: Mon, 30 May 2005 14:31:01 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: Maxim.Sobolev@portaone.com Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libstand Makefile Message-ID: <20050530113101.GH54585@ip.net.ua> In-Reply-To: <429AF57A.5060902@portaone.com> References: <200505292105.j4TL5w32038570@repoman.freebsd.org> <20050530104131.GB54585@ip.net.ua> <429AF57A.5060902@portaone.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--7J16OGEJ/mt06A90
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, May 30, 2005 at 02:14:02PM +0300, Maxim Sobolev wrote:
> Ruslan Ermilov wrote:
> >Hi,
> >
> >On Sun, May 29, 2005 at 09:05:58PM +0000, Maxim Sobolev wrote:
> >
> >>sobomax 2005-05-29 21:05:58 UTC
> >>
> >> FreeBSD src repository
> >>
> >> Modified files:
> >> lib/libstand Makefile=20
> >> Log:
> >> Add missed ${.CURDIR}/../../contrib/bzip2 into include search path,=20
> >> otherwise
> >> old version of bzlib.h can be picked up from the /usr/include.
> >>=20
> >> Revision Changes Path
> >> 1.51 +1 -1 src/lib/libstand/Makefile
> >>
> >
> >Changes like this, while harmless, unnecessarily pollute makefiles.
> >During buildworld we first install new headers then build new
> >libraries then the rest. When doing standalone compiles, the same
> >procedure should generally be followed. (Otherwise, you'd end up
> >changing every utility's makefile that uses libstand to add this
> >-I to CFLAGS.)
>=20
> This is incorrect assertion since libstand hides implementation details,=
=20
> so that it is not necessary to include bzlib.h into code which uses=20
> libstand.
>=20
But if you were to standalone test the build of loader(8) with an
updated libstand library, you'd have to (as an alternative to a full
"make buildworld"):
1. build/install updated headers
2. build/install updated libstand
3. build loader
My point was to let you know that what you did was not necessary for
a normal "make buildworld" case (contrary to the commit log), and is
only useful in standalone compile, and its usefullness is only
limited to building the library itself, not its consumers.
I don't ask you to take any actions, but if you feel like refining
a commit log this would be appreciated. :-)
Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
--7J16OGEJ/mt06A90
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (FreeBSD)
iD8DBQFCmvl1qRfpzJluFF4RAsLzAKCagYE7sjraCbsO8orUjsnaoeQisgCdGFDf
k1qehp3WoF9zcnuuXRNicNw=
=Dccx
-----END PGP SIGNATURE-----
--7J16OGEJ/mt06A90--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050530113101.GH54585>