Date: Thu, 25 Sep 2014 20:01:36 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r271201 - head/sys/dev/ahci Message-ID: <5424BAF0.2000902@FreeBSD.org> In-Reply-To: <4A1B4605-B3AE-4B8D-B039-AD1A86B561B8@bsdimp.com> References: <201409061820.s86IKpnw042259@svn.freebsd.org> <5424B0C0.30202@FreeBSD.org> <4A1B4605-B3AE-4B8D-B039-AD1A86B561B8@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sexQDWoQKTtDpARPcdoD4bs9tWlXrtmR0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 9/25/2014 7:59 PM, Warner Losh wrote: > Hey Bryan, >=20 > Sorry for the hassle. This didn=92t show up in the hardware I had, but = did show up in Mav=92s hardware. It was like this less than a day, I thou= ght=85 >=20 > Warner >=20 Yes only a day or two. I was just unlucky about it. Now I am able to get updated to latest head. >=20 > On Sep 25, 2014, at 5:18 PM, Bryan Drewery <bdrewery@FreeBSD.org> wrote= : >=20 >> This drove me crazy for the past few days! >> >> https://lists.freebsd.org/pipermail/freebsd-current/2014-September/052= 215.html >> >> Not sure about the first trace there, but the others I encountered wer= e >> due to this not being fixed yet. smh@ tracked the ordering down and th= en >> we found this. I couldn't try a newer build easily since my system wou= ld >> panic on just buildworld :) >> >> On 9/6/2014 1:20 PM, Warner Losh wrote: >>> Author: imp >>> Date: Sat Sep 6 18:20:50 2014 >>> New Revision: 271201 >>> URL: http://svnweb.freebsd.org/changeset/base/271201 >>> >>> Log: >>> Restore order of interrupt setup. Minor problems can result by >>> setting up the interrupts too early: >>> >>> Reviewed by: mav@ >>> Sponsored by: Netflix >>> >>> Modified: >>> head/sys/dev/ahci/ahci.c >>> head/sys/dev/ahci/ahci_pci.c >>> >>> Modified: head/sys/dev/ahci/ahci.c >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/sys/dev/ahci/ahci.c Sat Sep 6 18:08:21 2014 (r271200) >>> +++ head/sys/dev/ahci/ahci.c Sat Sep 6 18:20:50 2014 (r271201) >>> @@ -229,6 +229,15 @@ ahci_attach(device_t dev) >>> >>> ahci_ctlr_setup(dev); >>> >>> + /* Setup interrupts. */ >>> + if (ahci_setup_interrupt(dev)) { >>> + bus_dma_tag_destroy(ctlr->dma_tag); >>> + bus_release_resource(dev, SYS_RES_MEMORY, ctlr->r_rid, >>> + ctlr->r_mem); >>> + rman_fini(&ctlr->sc_iomem); >>> + return ENXIO; >>> + } >>> + >>> i =3D 0; >>> for (u =3D ctlr->ichannels; u !=3D 0; u >>=3D 1) >>> i +=3D (u & 1); >>> >>> Modified: head/sys/dev/ahci/ahci_pci.c >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/sys/dev/ahci/ahci_pci.c Sat Sep 6 18:08:21 2014 (r271200) >>> +++ head/sys/dev/ahci/ahci_pci.c Sat Sep 6 18:20:50 2014 (r271201) >>> @@ -417,13 +417,6 @@ ahci_pci_attach(device_t dev) >>> ctlr->numirqs =3D 1; >>> } >>> >>> - if (ahci_setup_interrupt(dev)) { >>> - if (ctlr->msi) >>> - pci_release_msi(dev); >>> - bus_release_resource(dev, SYS_RES_MEMORY, ctlr->r_rid, ctlr->r_mem= ); >>> - return ENXIO; >>> - } >>> - >>> error =3D ahci_attach(dev); >>> if (error !=3D 0) >>> if (ctlr->msi) >>> >> >> >> --=20 >> Regards, >> Bryan Drewery >> >=20 --=20 Regards, Bryan Drewery --sexQDWoQKTtDpARPcdoD4bs9tWlXrtmR0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUJLrxAAoJEDXXcbtuRpfP6QkH/0Kg2rJdU4eKDIMVUa45fdRr tx2bHmsB6g3ka+E5L98uMoWxFOiRPSgqifEQYSyxkKn04n2hOarvyRLtmkNInAO6 bepmJAuWSva/K5W0F0wu9RgFqe+KI3284kopKmuG6cVVFS62n8MLy6rShmESe5Gv daVWbyPELbBZ8vfMBXWhOnfXv0ywzDKPZMrHTs+AOKd70KgCVUUVsG487ZGDOYT7 s9lLlcx/lTvg/fcr+KakaWtugvnKmqQV1Mbmmkt+gikQaw6IPXr/cUSQxKXlxCDc aBRocIugYryaDihnAX0YiDwZqljQRopP5mDnpciqtjHCPpZ82pd83O2IA0ERbCs= =32pZ -----END PGP SIGNATURE----- --sexQDWoQKTtDpARPcdoD4bs9tWlXrtmR0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5424BAF0.2000902>