Date: Fri, 24 Jan 2014 09:23:51 -0700 (MST) From: Warren Block <wblock@wonkity.com> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: doc@freebsd.org, Pietro Cerutti <gahr@FreeBSD.org> Subject: Re: [patch] PH tells crap about GMAKE (Was: Re: svn commit: r340018 - head/textproc/scew) Message-ID: <alpine.BSF.2.00.1401240922210.87046@wonkity.com> In-Reply-To: <20140117141440.GA94157@FreeBSD.org> References: <201401170910.s0H9Aw9O087448@svn.freebsd.org> <20140117093546.GA16656@FreeBSD.org> <20140117095020.GD4006@gahrfit.gahr.ch> <20140117141440.GA94157@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
--3512871622-1184828063-1390580631=:87046
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Fri, 17 Jan 2014, Alexey Dokuchaev wrote:
> On Fri, Jan 17, 2014 at 10:50:21AM +0100, Pietro Cerutti wrote:
>> On 2014-Jan-17, 09:35, Alexey Dokuchaev wrote:
>>> If possible, particular make(1) implementation should not be referenced in
>>> port's Makefile. If you need to call "correct" make(1), use ${MAKE_CMD},
>>> which would be correctly set to "gmake" in this case of yours (per USES=
>>> gmake).
>>
>> That makes sense. What about updating [section] 6.4.2 of the porter's
>> handbook?
>
> Indeed, this section needs some love. Even more, I think it tells something
> that is not true: "GMAKE [variables contains] The full path for gmake if it
> is not in the PATH."
>
> GMAKE is defined in Mk/bsd.commands.mk, and equals to simply "gmake". It
> is one of the rare cases when absolute (or relative to ${LOCALBASE}) path
> is not used. I did not observe any indication of some PATH inspection to
> conditionally set GMAKE variable under /usr/ports/Mk.
>
> I also think that Table 6.1 which consists of two rows and columns is, hm,
> ridicule, I guess. :) IMHO it should be removed.
>
> Please consider attached patch. It is not a polished gem, and most likely
> would need a review and wordsmithing from doc@ guys.
>
> While here I've also standardized the spelling of "okay", and fixed couple
> of grammar nits. These changes are not related to GMAKE ones, and probably
> should be committed separately, but I'm not splitting the diff for personal
> convenience, sorry. :)
Attached is a quick editing pass. I have not tested it for building
yet, and edited the diff directly, so it has some a new blank line.
--3512871622-1184828063-1390580631=:87046
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=ph-gmake.diff
Content-Transfer-Encoding: BASE64
Content-ID: <alpine.BSF.2.00.1401240923510.87046@wonkity.com>
Content-Description:
Content-Disposition: attachment; filename=ph-gmake.diff
SW5kZXg6IGJvb2sueG1sDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0g
Ym9vay54bWwJKHJldmlzaW9uIDQzNTU0KQ0KKysrIGJvb2sueG1sCSh3b3Jr
aW5nIGNvcHkpDQpAQCAtMjAxLDcgKzIwMSw3IEBADQogCSAgICA8ZmlsZW5h
bWU+UkVBRE1FPC9maWxlbmFtZT4gb3IgbWFucGFnZTwvZW1waGFzaXM+OyB0
b28NCiAJICAgIG9mdGVuIHRoZXkgYXJlIG5vdCBhIGNvbmNpc2UgZGVzY3Jp
cHRpb24gb2YgdGhlIHBvcnQgb3INCiAJICAgIGFyZSBpbiBhbiBhd2t3YXJk
IGZvcm1hdCAoZS5nLiwgbWFucGFnZXMgaGF2ZSBqdXN0aWZpZWQNCi0JICAg
IHNwYWNpbmcsIGFzIGl0IGxvb2tzIHBhcnRpY3VsYXJseSBiYWQgd2l0aCBt
b25vc3BhY2VkDQorCSAgICBzcGFjaW5nLCB3aGljaCBsb29rcyBwYXJ0aWN1
bGFybHkgYmFkIHdpdGggbW9ub3NwYWNlZA0KIAkgICAgZm9udHMpLjwvcGFy
YT4NCiAJPC9ub3RlPg0KIA0KQEAgLTUxNSw3ICs1MTUsNyBAQA0KICAgPGNo
YXB0ZXIgeG1sOmlkPSJzbG93Ij4NCiAgICAgPHRpdGxlPlNsb3cgUG9ydGlu
ZzwvdGl0bGU+DQogDQotICAgIDxwYXJhPk9rLCBzbyBpdCB3YXMgbm90IHRo
YXQgc2ltcGxlLCBhbmQgdGhlIHBvcnQgcmVxdWlyZWQgc29tZQ0KKyAgICA8
cGFyYT5Pa2F5LCBzbyBpdCB3YXMgbm90IHRoYXQgc2ltcGxlLCBhbmQgdGhl
IHBvcnQgcmVxdWlyZWQgc29tZQ0KICAgICAgIG1vZGlmaWNhdGlvbnMgdG8g
Z2V0IGl0IHRvIHdvcmsuICBJbiB0aGlzIHNlY3Rpb24sIHdlIHdpbGwNCiAg
ICAgICBleHBsYWluLCBzdGVwIGJ5IHN0ZXAsIGhvdyB0byBtb2RpZnkgaXQg
dG8gZ2V0IGl0IHRvIHdvcmsgd2l0aA0KICAgICAgIHRoZSBwb3J0cyBwYXJh
ZGlnbS48L3BhcmE+DQpAQCAtNDEyOCw3ICs0MTI4LDcgQEANCiANCiAJPHBh
cmE+QXZhaWxhYmxlIDx2YXJuYW1lPlVTRV88L3Zhcm5hbWU+IGFuZA0KIAkg
IDx2YXJuYW1lPldBTlRfPC92YXJuYW1lPiB2YXJpYWJsZXMgYXJlIGRlZmlu
ZWQgaW4gdGhlIGZpbGVzDQotCSAgaW4gPGZpbGVuYW1lPi91c3IvcG9ydHMv
TWs8L2ZpbGVuYW1lPi48L3BhcmE+DQorCSAgaW4gPGZpbGVuYW1lIGNsYXNz
PSJkaXJlY3RvcnkiPi91c3IvcG9ydHMvTWsvPC9maWxlbmFtZT4uPC9wYXJh
Pg0KICAgICAgIDwvc2VjdDI+DQogICAgIDwvc2VjdDE+DQogDQpAQCAtNTY0
NCw0MCArNTY0NCwzMiBAQA0KICAgICAgIDwvc2VjdDI+DQogDQogICAgICAg
PHNlY3QyIHhtbDppZD0idXNpbmctbWFrZSI+DQotCTx0aXRsZT48Y29tbWFu
ZD5tYWtlPC9jb21tYW5kPiwgPGNvbW1hbmQ+Z21ha2U8L2NvbW1hbmQ+LCBh
bmQNCi0JICA8Y29tbWFuZD5pbWFrZTwvY29tbWFuZD48L3RpdGxlPg0KKwk8
dGl0bGU+PGNvbW1hbmQ+bWFrZTwvY29tbWFuZD4sIDxjb21tYW5kPmdtYWtl
PC9jb21tYW5kPiwNCisJICA8Y29tbWFuZD5mbWFrZTwvY29tbWFuZD4sIGFu
ZCA8Y29tbWFuZD5pbWFrZTwvY29tbWFuZD48L3RpdGxlPg0KIA0KKwk8cGFy
YT5TZXZlcmFsIDxsaXRlcmFsPm1ha2U8L2xpdGVyYWw+IGltcGxlbWVudGF0
aW9ucyBleGlzdCBhbmQNCisJICBhcmUgaW4gdXNlLiAgUXVpdGUgb2Z0ZW4s
IGEgc3BlY2lmaWMgaW1wbGVtZW50YXRpb24gaXMgcmVxdWlyZWQsDQorCSAg
bGlrZSBHTlUgbWFrZSwgb3IgbGVnYWN5ICZvczsgbWFrZS48L3BhcmE+DQor
DQogCTxwYXJhPklmIHlvdXIgcG9ydCB1c2VzIDxhcHBsaWNhdGlvbj5HTlUg
bWFrZTwvYXBwbGljYXRpb24+LA0KLQkgIHNldCA8bGl0ZXJhbD5VU0VTPSBn
bWFrZTwvbGl0ZXJhbD4uPC9wYXJhPg0KKwkgIGFkZCA8bGl0ZXJhbD5nbWFr
ZTwvbGl0ZXJhbD4gdG8gPGxpdGVyYWw+VVNFUzwvbGl0ZXJhbD4uICBJZg0K
KwkgIHRoZSBsZWdhY3kgJm9zOyA8Y29tbWFuZD5tYWtlPC9jb21tYW5kPiBp
cyBuZWVkZWQsIGFkZCA8bGl0ZXJhbD5mbWFrZTwvbGl0ZXJhbD4NCisJICB0
aGVyZS48L3BhcmE+DQogDQotCTx0YWJsZSBmcmFtZT0ibm9uZSI+DQotCSAg
PHRpdGxlPlZhcmlhYmxlcyBmb3IgUG9ydHMgUmVsYXRlZCB0bw0KLQkgICAg
PGFwcGxpY2F0aW9uPmdtYWtlPC9hcHBsaWNhdGlvbj48L3RpdGxlPg0KKwk8
cGFyYT5UbyByZWZlcmVuY2UgYSBzcGVjaWZpYyA8Y29tbWFuZD5tYWtlPC9j
b21tYW5kPiBjb21tYW5kDQorCSAgdGhhdCBkZXBlbmRzIG9uIDxsaXRlcmFs
PlVTRVM8L2xpdGVyYWw+IHZhbHVlIGluIGEgcG9ydCdzDQorCSAgPGZpbGVu
YW1lPk1ha2VmaWxlPC9maWxlbmFtZT4sIHVzZQ0KKwkgIDx2YXJuYW1lPk1B
S0VfQ01EPC92YXJuYW1lPi4gIEluIHJhcmUgY2FzZXMgd2hlcmUNCisJICBz
ZXZlcmFsIGRpZmZlcmVudCA8bGl0ZXJhbD5tYWtlPC9saXRlcmFsPiBpbXBs
ZW1lbnRhdGlvbnMgYXJlIGxpc3RlZA0KKwkgIGluIDxsaXRlcmFsPlVTRVM8
L2xpdGVyYWw+LCB0aGUgdmFyaWFibGVzDQorCSAgPHZhcm5hbWU+R01BS0U8
L3Zhcm5hbWU+IChmb3IgR05VIHZlcnNpb24pIG9yDQorCSAgPHZhcm5hbWU+
Rk1BS0U8L3Zhcm5hbWU+IChmb3IgbGVnYWN5ICZvczsgdmVyc2lvbikgYXJl
IGF2YWlsYWJsZS4NCisJICANCisJICBNb3N0DQorCSAgcG9ydHMgc2hvdWxk
IG9ubHkgdXNlIDx2YXJuYW1lPk1BS0VfQ01EPC92YXJuYW1lPiB3aXRoaW4N
CisJICB0aGVpciA8ZmlsZW5hbWU+TWFrZWZpbGU8L2ZpbGVuYW1lPnMgKHRo
YXQgaXMsIHRvIGNhbGwgdGhlIDxjb21tYW5kPm1ha2U8L2NvbW1hbmQ+DQor
CSAgaW1wbGVtZW50YXRpb24gZXhwZWN0ZWQgYnkgdGhlIHBvcnRlZCBzb2Z0
d2FyZSkuPC9wYXJhPg0KIA0KLQkgIDx0Z3JvdXAgY29scz0iMiI+DQotCSAg
ICA8dGhlYWQ+DQotCSAgICAgIDxyb3c+DQotCQk8ZW50cnk+VmFyaWFibGU8
L2VudHJ5Pg0KLQkJPGVudHJ5Pk1lYW5zPC9lbnRyeT4NCi0JICAgICAgPC9y
b3c+DQotCSAgICA8L3RoZWFkPg0KLQ0KLQkgICAgPHRib2R5Pg0KLQkgICAg
ICA8cm93Pg0KLQkJPGVudHJ5Pjx2YXJuYW1lPlVTRVM9IGdtYWtlPC92YXJu
YW1lPjwvZW50cnk+DQotCQk8ZW50cnk+VGhlIHBvcnQgcmVxdWlyZXMgPGNv
bW1hbmQ+Z21ha2U8L2NvbW1hbmQ+IHRvDQotCQkgIGJ1aWxkLjwvZW50cnk+
DQotCSAgICAgIDwvcm93Pg0KLQ0KLQkgICAgICA8cm93Pg0KLQkJPGVudHJ5
Pjx2YXJuYW1lPkdNQUtFPC92YXJuYW1lPjwvZW50cnk+DQotCQk8ZW50cnk+
VGhlIGZ1bGwgcGF0aCBmb3IgPGNvbW1hbmQ+Z21ha2U8L2NvbW1hbmQ+IGlm
DQotCQkgIGl0IGlzIG5vdCBpbiB0aGUgPGVudmFyPlBBVEg8L2VudmFyPi48
L2VudHJ5Pg0KLQkgICAgICA8L3Jvdz4NCi0JICAgIDwvdGJvZHk+DQotCSAg
PC90Z3JvdXA+DQotCTwvdGFibGU+DQotDQogCTxwYXJhPklmIHlvdXIgcG9y
dCBpcyBhbiBYIGFwcGxpY2F0aW9uIHRoYXQgY3JlYXRlcw0KIAkgIDxmaWxl
bmFtZT5NYWtlZmlsZTwvZmlsZW5hbWU+IGZpbGVzIGZyb20NCiAJICA8Zmls
ZW5hbWU+SW1ha2VmaWxlPC9maWxlbmFtZT4gZmlsZXMgdXNpbmcNCg==
--3512871622-1184828063-1390580631=:87046--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1401240922210.87046>