Date: Fri, 14 Dec 2007 00:15:43 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Kip Macy <kmacy@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files src/sys/netinet tcp_ofld.c tcp_ofld.h tcp_var.h toedev.h src/sys/sys socket.h Message-ID: <20071214001219.M86532@fledge.watson.org> In-Reply-To: <20071213223319.E81630@maildrop.int.zabbadoz.net> References: <200712122021.lBCKLdvt045540@repoman.freebsd.org> <20071213223319.E81630@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 13 Dec 2007, Bjoern A. Zeeb wrote: > I consider that just for the archives .. > > .. but is there a reason you abbreviated those file names like that? It's > not like we live with 8.3 contrainsts. > > The first time I parsed it as "of ld", then realiazed it should be "off ld" > and then wondered why it wasn't just "offload" like it is "syncache" or > "timewait" or "hostcache"? > > And yes, I wondered the same about the functions names, ... > > Was that spelling inherited from another implementation/standard/whatever? I raised a similar question about function naming -- generally TCP is pretty good about naming functions tcp_foo, and I'd like it if we used that convention here also. The prefix ofld, while unlikely to immediately collide, doesn't follow those conventions. Per out-of-band discussion which I won't rehash in any detail, I'd also prefer if this sort of change were discussed on arch@/net@/etc in advance of commit. For those following this work, Kip has posted the next batch of changes to arch@ soif people could take this opportunity to review them before they go in, that would be great :-). Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071214001219.M86532>