Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 9 Mar 2025 20:45:00 GMT
From:      Vladimir Kondratyev <wulf@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: f05f6d93732e - stable/14 - acpi_gpiobus: assume GPIO_PIN_INPUT for interrupt pins
Message-ID:  <202503092045.529Kj0oR089466@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by wulf:

URL: https://cgit.FreeBSD.org/src/commit/?id=f05f6d93732e7d58464352e97e2dcafbab94adc4

commit f05f6d93732e7d58464352e97e2dcafbab94adc4
Author:     Ahmad Khalifa <ahmadkhalifa570@gmail.com>
AuthorDate: 2025-03-07 15:59:11 +0000
Commit:     Vladimir Kondratyev <wulf@FreeBSD.org>
CommitDate: 2025-03-09 20:42:13 +0000

    acpi_gpiobus: assume GPIO_PIN_INPUT for interrupt pins
    
    Different drivers respond differently to having neither GPIO_PIN_INPUT
    or GPIO_PIN_OUTPUT set, this stops the unpredictable results.
    
    (cherry picked from commit 6aab381a498f1a43ba372f4ae9f57ef88b4767b5)
---
 sys/dev/gpio/acpi_gpiobus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sys/dev/gpio/acpi_gpiobus.c b/sys/dev/gpio/acpi_gpiobus.c
index 254bb951177d..833b6984ae05 100644
--- a/sys/dev/gpio/acpi_gpiobus.c
+++ b/sys/dev/gpio/acpi_gpiobus.c
@@ -77,6 +77,7 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res)
 			break;
 		}
 
+		flags |= GPIO_PIN_INPUT;
 #ifdef NOT_YET
 		/* This is not currently implemented. */
 		if (gpio_res->Shareable == ACPI_SHARED)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202503092045.529Kj0oR089466>