Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 Aug 2010 19:40:39 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Martin Matuska <mm@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r211932 - in head/sys/cddl: compat/opensolaris/kern compat/opensolaris/sys contrib/opensolaris/uts/common contrib/opensolaris/uts/common/fs/zfs contrib/opensolaris/uts/common/fs/zfs/sys...
Message-ID:  <20100828174039.GK2077@garage.freebsd.pl>
In-Reply-To: <201008280924.o7S9OBgU025468@svn.freebsd.org>
References:  <201008280924.o7S9OBgU025468@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--zPXeIxDajdrcF2en
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Aug 28, 2010 at 09:24:11AM +0000, Martin Matuska wrote:
> Author: mm
> Date: Sat Aug 28 09:24:11 2010
> New Revision: 211932
> URL: http://svn.freebsd.org/changeset/base/211932
>=20
> Log:
>   Import changes from OpenSolaris that provide
>   - better ACL caching and speedup of ACL permission checks
>   - faster handling of stat()
>   - lowered mutex contention in the read/writer lock (rrwlock)
>   - several related bugfixes
>  =20
>   Detailed information (OpenSolaris onnv changesets and Bug IDs):
>  =20
>   9749:105f407a2680
>   6802734	Support for Access Based Enumeration (not used on FreeBSD)
>   6844861	inconsistent xattr readdir behavior with too-small buffer
>  =20
>   9866:ddc5f1d8eb4e
>   6848431	zfs with rstchown=3D0 or file_chown_self privilege allows user =
to "take" ownership
>  =20
>   9981:b4907297e740
>   6775100	stat() performance on files on zfs should be improved
>   6827779	rrwlock is overly protective of its counters
>  =20
>   10143:d2d432dfe597
>   6857433	memory leaks found at: zfs_acl_alloc/zfs_acl_node_alloc
>   6860318	truncate() on zfsroot succeeds when file has a component of its=
 path set without access permission
>  =20
>   10232:f37b85f7e03e
>   6865875	zfs sometimes incorrectly giving search access to a dir
>  =20
>   10250:b179ceb34b62
>   6867395	zpool_upgrade_007_pos testcase panic'd with BAD TRAP: type=3De =
(#pf Page fault)
>  =20
>   10269:2788675568fd
>   6868276	zfs_rezget() can be hazardous when znode has a cached ACL
>  =20
>   10295:f7a18a1e9610
>   6870564	panic in zfs_getsecattr
>  =20
>   Approved by:	delphij (mentor)
>   Obtained from:	OpenSolaris (multiple Bug IDs)
>   MFC after:	2 weeks
[...]
> --- head/sys/cddl/contrib/opensolaris/uts/common/Makefile.files	Sat Aug 2=
8 08:59:55 2010	(r211931)
> +++ head/sys/cddl/contrib/opensolaris/uts/common/Makefile.files	Sat Aug 2=
8 09:24:11 2010	(r211932)
> @@ -19,6 +19,9 @@
>  # CDDL HEADER END
>  #
> =20
> +ZUT_OBJS +=3D			\
> +	zut.o
> +
>  #
>  # Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
>  # Use is subject to license terms.
[...]
> --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/rrwlock.c	Sat Aug=
 28 08:59:55 2010	(r211931)
> +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/rrwlock.c	Sat Aug=
 28 09:24:11 2010	(r211932)
[...]
> @@ -84,7 +82,7 @@ rrn_find(rrwlock_t *rrl)
>  	rrw_node_t *rn;
> =20
>  	if (refcount_count(&rrl->rr_linked_rcount) =3D=3D 0)
> -		return (NULL);
> +		return (B_FALSE);
> =20
>  	for (rn =3D tsd_get(rrw_tsd_key); rn !=3D NULL; rn =3D rn->rn_next) {
>  		if (rn->rn_rrl =3D=3D rrl)

Those two chunks are incorrect, please consult my p4 branch.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--zPXeIxDajdrcF2en
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iEYEARECAAYFAkx5ShYACgkQForvXbEpPzTWxgCgwLN01ElBY1uPLzm3Wy4AEpHK
NQYAniB6L42r3bvjsGOWeYmkH7gZ8UX2
=DzFP
-----END PGP SIGNATURE-----

--zPXeIxDajdrcF2en--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100828174039.GK2077>