Date: Thu, 20 Sep 2007 10:19:07 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Roman Divacky <rdivacky@freebsd.org> Cc: freebsd-emulation@freebsd.org, sam <samflanker@gmail.com> Subject: Re: linuxolator problem on i386 Message-ID: <20070920101907.uxb5zxel8g00g4s0@webmail.leidinger.net> In-Reply-To: <20070919132546.GA35553@freebsd.org> References: <46EF7E05.5040405@gmail.com> <20070918074332.GA30053@freebsd.org> <88000019@srv.sem.ipt.ru> <20070918082119.GA30932@freebsd.org> <89768331@srv.sem.ipt.ru> <41596338@srv.sem.ipt.ru> <20070919085405.GA24442@freebsd.org> <18395962@srv.sem.ipt.ru> <20070919111557.GA28377@freebsd.org> <75502368@srv.sem.ipt.ru> <20070919132546.GA35553@freebsd.org>
index | next in thread | previous in thread | raw e-mail
Quoting Roman Divacky <rdivacky@freebsd.org> (from Wed, 19 Sep 2007 15:25:46 +0200): >> > @@ -442,8 +443,7 @@ >> >> > off = fp->f_offset; >> >> > - buflen = max(LINUX_DIRBLKSIZ, nbytes); >> > - buflen = min(buflen, MAXBSIZE); >> > + buflen = max(buflen, MAXBSIZE); >> > buf = malloc(buflen, M_TEMP, M_WAITOK); >> > vn_lock(vp, LK_EXCLUSIVE | LK_RETRY, td); >> >> No. It limits buflen to which is smaller, buflen or MAXBSIZE. > > yes... brain does not work real good today :( > > I wonder why the limitation is there. Isn't this the code where we made sure that we don't use more buffer than we have? In some part of the code we specially made sure that we don't overflow either the FreeBSD size nor the linux size. You could check if nbytes is with or without the \0. Bye, Alexander. -- People never lie so much as after a hunt, during a war, or before an election. -- Otto von Bismarck http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070920101907.uxb5zxel8g00g4s0>