Date: Wed, 17 Jan 2018 10:51:56 -0800 From: Freddie Cash <fjwcash@gmail.com> To: =?UTF-8?Q?Martin_Waschb=C3=BCsch?= <martin@waschbuesch.de> Cc: Adam Weinberger <adamw@adamw.org>, freebsd-ports <freebsd-ports@freebsd.org> Subject: Re: Help with versioning scheme Message-ID: <CAOjFWZ6NHiO%2BZX_ij=y6hLHLwGtBRepa5MEw2fADwVAH9fpL7A@mail.gmail.com> In-Reply-To: <638AE69B-CB7C-41E1-9CA8-D0B9E2A6BC32@waschbuesch.de> References: <F35F7011-4DDA-4BD4-93FB-BE75ECD49827@waschbuesch.de> <C655A3CB-8C52-4CB0-A6F4-F34EAD224175@adamw.org> <D3D2C74D-DA67-4B8D-96C3-4E1E2928D815@waschbuesch.de> <CAOjFWZ7xMcSQWRYAfaSA%2Baxm9de9bdsikqRZJfZXbsEb8%2B_oSg@mail.gmail.com> <638AE69B-CB7C-41E1-9CA8-D0B9E2A6BC32@waschbuesch.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 17, 2018 at 10:40 AM, Martin Waschb=C3=BCsch <martin@waschbuesc=
h.de>
wrote:
> Thanks, Freddie,
>
> Am 17.01.2018 um 19:35 schrieb Freddie Cash <fjwcash@gmail.com>:
>
> On Wed, Jan 17, 2018 at 10:29 AM, Martin Waschb=C3=BCsch <martin@waschbue=
sch.de
> > wrote:
>
>> Hi Adam,
>> > Am 17.01.2018 um 19:19 schrieb Adam Weinberger <adamw@adamw.org>:
>> > Hi Martin,
>> >
>> > You don't want to use the upstream version to represent PORTREVISION.
>> PORTREVISION is for when you need to force rebuilds of the port itself, =
and
>> so tying it to upstream would make it impossible to bump it ourselves.
>> >
>> > Why do you need to ignore the fourth digit? It's perfectly valid for
>> our purposes.
>>
>> So far, I had (because it coincided with their version number) used it t=
o
>> provide SO_VER. But that breaks now:
>>
>> ---
>> # Created by: adamw
>> # $FreeBSD: head/archivers/liblz4/Makefile 448415 2017-08-20 12:30:25Z
>> sunpoet $
>>
>> PORTNAME=3D lz4
>> PORTVERSION=3D 1.8.1
>> DISTVERSIONPREFIX=3D v
>> PORTEPOCH=3D 1
>> CATEGORIES=3D archivers
>> PKGNAMEPREFIX=3D lib
>>
>> MAINTAINER=3D martin@waschbuesch.de
>> COMMENT=3D LZ4 compression library, lossless and very fast
>>
>> LICENSE=3D BSD2CLAUSE GPLv2
>> LICENSE_COMB=3D multi
>>
>> USES=3D gmake pathfix pkgconfig
>> USE_GITHUB=3D yes
>> USE_LDCONFIG=3D yes
>> #PATHFIX_MAKEFILEIN=3D Makefile
>>
>> ALL_TARGET=3D default # don't remove this
>> SO_VER=3D ${PORTVERSION}
>> PLIST_SUB+=3D SO_VER=3D${SO_VER} SO_VER_MAJ=3D${SO_VER:R:R}
>>
>
> =E2=80=8BWhy can't you do something like the above to get SO_VER?
>
> PORTVERSION=3D1.8.1.2
> SO_VER=3D${PORTVERSION:R:R:R)
>
> Similar to how you get SO_VER_MAJ out of SO_VER.=E2=80=8B
>
>
> That is true. Do you think this is a robust solution, though?
> Or is the whole relying on upstream variables idea problematic?
>
=E2=80=8BSo long as they continue to have =E2=80=8B4 digit version numbers =
(meaning 1.9.0.0
and not just 1.9), then everything will be fine.
If upstream does weird things with their version numbers (1.8.1.2 --> 1.8.2
--> 1.9 --> 2 --> 2.1 --> 2.1.1 --> 2.1.1.1), then you'll have to manually
massage things in the port Makefile with each update.
Hopefully, they don't do that, and keep things logical (1.8.1.2 --> 1.8.2.0
--> 1.9.0.0 --> 2.0.0.0 --> 2.1.0.0 --> 2.1.1.0 --> 2.1.1.1) which would
make things simpler on your end. :)
--=20
Freddie Cash
fjwcash@gmail.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOjFWZ6NHiO%2BZX_ij=y6hLHLwGtBRepa5MEw2fADwVAH9fpL7A>